Issue 3012263002: Move log_count_ out of RtcEventLogImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3012263002: Move log_count_ out of RtcEventLogImpl (Closed)

Created:
3 years, 3 months ago by eladalon

Modified:
3 years, 3 months ago

Reviewers:
terelius

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Move log_count_ out of RtcEventLogImpl The limit on logs is not specific to the implementation of the logs, but is rather shared between all possible logs. Also, by making it local to the .cc, not a member, we reduce the necessity of making RtcEventLog::Create a friend of the implementation. This necessity is removed completely by a following CL. BUG=webrtc:8111

Patch Set 1 #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	webrtc/logging/rtc_event_log/rtc_event_log.cc	View		5 chunks	+9 lines, -11 lines	0 comments	Download

Depends on Patchset:

Issue 3016463002 Patch 1

Dependent Patchsets:

Issue 3014503002 Patch 1

Issue 3014503002 Patch 20001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eladalon

3 years, 3 months ago (2017-09-14 14:54:24 UTC) #3

Please continue reviewing here:
https://webrtc-review.googlesource.com/#/c/src/+/1236

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages