Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 301163005: DevTools: [JSDoc] Avoid partial arg list annotations in code except "profiler" module (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [JSDoc] Avoid partial arg list annotations in code except "profiler" module This patch also fixes some ?Event -> !Event cases. R=vsevik@chromium.org, lushnikov, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175278

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment addressed #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -24 lines) Patch
M Source/devtools/front_end/EditFileSystemDialog.js View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ScreencastView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/SettingsScreen.js View 1 3 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/DOMExtension.js View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/ModuleManager.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/common/utilities.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/HandlerRegistry.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/Panel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 8 chunks +22 lines, -8 lines 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionAPI.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/RequestJSONView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/network/RequestPreviewView.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 3 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/Database.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/FileUtils.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/IndexedDBModel.js View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/IsolatedFileSystem.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceScriptMapping.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/UISourceCode.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerManager.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/BreakpointsSidebarPane.js View 3 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/CallStackSidebarPane.js View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesNavigator.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 3 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/Checkbox.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/ContextMenu.js View 1 7 chunks +15 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ui/TextPrompt.js View 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/treeoutline.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
apavlov
6 years, 6 months ago (2014-05-30 14:26:11 UTC) #1
vsevik
lgtm I suggest that you land the patches that only add typing information or make ...
6 years, 6 months ago (2014-06-02 09:06:48 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/301163005/diff/1/Source/devtools/front_end/ui/ContextMenu.js File Source/devtools/front_end/ui/ContextMenu.js (right): https://chromiumcodereview.appspot.com/301163005/diff/1/Source/devtools/front_end/ui/ContextMenu.js#newcode290 Source/devtools/front_end/ui/ContextMenu.js:290: * @param {?Event} event Why not !Event?
6 years, 6 months ago (2014-06-02 09:07:01 UTC) #3
apavlov
On 2014/06/02 09:07:01, vsevik wrote: > https://chromiumcodereview.appspot.com/301163005/diff/1/Source/devtools/front_end/ui/ContextMenu.js > File Source/devtools/front_end/ui/ContextMenu.js (right): > > https://chromiumcodereview.appspot.com/301163005/diff/1/Source/devtools/front_end/ui/ContextMenu.js#newcode290 > ...
6 years, 6 months ago (2014-06-02 10:26:29 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-02 10:27:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/301163005/20001
6 years, 6 months ago (2014-06-02 10:27:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-02 11:41:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 11:44:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10336)
6 years, 6 months ago (2014-06-02 11:44:01 UTC) #9
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-02 11:53:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/301163005/40001
6 years, 6 months ago (2014-06-02 11:54:12 UTC) #11
apavlov
6 years, 6 months ago (2014-06-02 12:22:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 manually as r175278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698