Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Side by Side Diff: netlog_viewer/README.md

Issue 3011363002: Apply Chromium changes up to commit 0036296a1128ac9cbefeaff51c8df831ec421c36 (Closed)
Patch Set: address comments Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | netlog_viewer/netlog_viewer/alt_svc_view.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 A standalone WebApp for viewing chrome://net-export 1 A standalone WebApp for viewing chrome://net-export
2 [NetLog](https://www.chromium.org/developers/design-documents/network-stack/netl og) dump files 2 [NetLog](https://www.chromium.org/developers/design-documents/network-stack/netl og) dump files
3 ============ 3 ============
4 4
5 Introduction 5 Introduction
6 ------------ 6 ------------
7 This is a WebApp that allows someone to perform post-mortem analysis of a 7 This is a WebApp that allows someone to perform post-mortem analysis of a
8 saved NetLog dump. The initial code was taken out of Chromium. 8 saved NetLog dump. The initial code was taken out of Chromium.
9 The code should contain all changes made to net-internals up to chromium commit 9 The code should contain all changes made to net-internals up to chromium commit
10 8491b5b9060b61c2b06f51bb5dfcc8098c0cbad1. 10 0036296a1128ac9cbefeaff51c8df831ec421c36. The full design doc can be found
11 The full design doc can be found
12 [here](https://docs.google.com/document/d/1Ll7T5cguj5m2DqkUTad5DWRCqtbQ3L1q9FRvT N5-Y28/edit#). 11 [here](https://docs.google.com/document/d/1Ll7T5cguj5m2DqkUTad5DWRCqtbQ3L1q9FRvT N5-Y28/edit#).
13 12
13 Suggested merge steps:
14
15 1.
16 ```
17 git diff --relative --src-prefix="a/netlog_viewer/netlog_viewer/"\
18 --dst-prefix="b/netlog_viewer/netlog_viewer/"\
19 R1 R2 . > diff.txt
20 ```
21 where R1 and R2 are Chromium commit hashes.
22
23 2.
24 ```
25 cd CATAPULT_DIR;
26 git apply --reject --whitespace=fix diff.txt
27 ```
28
29 3.
30 Manually merge any rejected chunks in `*.rej` files.
31
14 Motivation 32 Motivation
15 ------------ 33 ------------
16 There are a few problems with the current system of logging network events 34 There are a few problems with the current system of logging network events
17 within Chromium (see chrome://net-internals) that motivated the design and 35 within Chromium (see chrome://net-internals) that motivated the design and
18 creation of this new project: 36 creation of this new project:
19 - Attempting to add new and improved functionalities to network logging within 37 - Attempting to add new and improved functionalities to network logging within
20 Chromium comes at the cost of bloating the Chromium binaries. 38 Chromium comes at the cost of bloating the Chromium binaries.
21 - The renderer process behind chrome://net-internals is privileged meaning it 39 - The renderer process behind chrome://net-internals is privileged meaning it
22 can ask the browser process to do more--monitoring networking events in this 40 can ask the browser process to do more--monitoring networking events in this
23 case. Generally, privileged UI on Chrome should be minmially complex and 41 case. Generally, privileged UI on Chrome should be minmially complex and
24 small in size, but a large chunk of chrome://net-internals is neither leaving 42 small in size, but a large chunk of chrome://net-internals is neither leaving
25 behind a rather large attack surface. 43 behind a rather large attack surface.
26 - The lack of chrome://net-export on desktop as outlined in an 44 - The lack of chrome://net-export on desktop as outlined in an
27 [issue](https://bugs.chromium.org/p/chromium/issues/detail?id=472706) 45 [issue](https://bugs.chromium.org/p/chromium/issues/detail?id=472706)
(...skipping 16 matching lines...) Expand all
44 Serve the files from an HTTP localhost server with: 62 Serve the files from an HTTP localhost server with:
45 63
46 python -m SimpleHTTPServer 8080 64 python -m SimpleHTTPServer 8080
47 65
48 Visit http://localhost:8080/index.html in your web browser to view the 66 Visit http://localhost:8080/index.html in your web browser to view the
49 netlog viewer. You will be able to click "Choose File" which will allow you to 67 netlog viewer. You will be able to click "Choose File" which will allow you to
50 select the file you exported earlier. From there your NetLog dump will appear 68 select the file you exported earlier. From there your NetLog dump will appear
51 as a table filled with all the dump's information. Visit the other tabs to 69 as a table filled with all the dump's information. Visit the other tabs to
52 view additional information! There are seven tabs that are currently fully 70 view additional information! There are seven tabs that are currently fully
53 functional (Import, Events, Proxy, Timeline, DNS, Sockets, Cache). 71 functional (Import, Events, Proxy, Timeline, DNS, Sockets, Cache).
OLDNEW
« no previous file with comments | « no previous file | netlog_viewer/netlog_viewer/alt_svc_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698