Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tracing/tracing/value/histogram_set.py

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram_set.html ('k') | tracing/tracing/value/histogram_set_hierarchy.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_set.py
diff --git a/tracing/tracing/value/histogram_set.py b/tracing/tracing/value/histogram_set.py
index e06a4d02e4e488c44c7e9d7c6f0443bc3de707b8..b60010d02c0a11bcabe24ed1a29776d35093c58a 100644
--- a/tracing/tracing/value/histogram_set.py
+++ b/tracing/tracing/value/histogram_set.py
@@ -51,20 +51,8 @@ class HistogramSet(object):
return self._shared_diagnostics_by_guid.get(guid)
def ResolveRelatedHistograms(self):
- histograms = self
- def HandleDiagnosticMap(dm):
- for diag in dm.itervalues():
- if isinstance(diag, histogram_module.RelatedHistogramMap):
- diag.Resolve(histograms)
-
for hist in self:
hist.diagnostics.ResolveSharedDiagnostics(self)
- HandleDiagnosticMap(hist.diagnostics)
- for dm in hist.nan_diagnostic_maps:
- HandleDiagnosticMap(dm)
- for hbin in hist.bins:
- for dm in hbin.diagnostic_maps:
- HandleDiagnosticMap(dm)
def __len__(self):
return len(self._histograms_by_guid)
« no previous file with comments | « tracing/tracing/value/histogram_set.html ('k') | tracing/tracing/value/histogram_set_hierarchy.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698