Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/diagnostics/tag_map.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html
diff --git a/tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html b/tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html
index 286afa09ef4eea3d8ed7e6401e5ab47380c18e3a..3bffc75caf0182a9ff810c8876be1f1fe17caf13 100644
--- a/tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html
+++ b/tracing/tracing/value/diagnostics/unmergeable_diagnostic_set.html
@@ -59,23 +59,6 @@ tr.exportTo('tr.v.d', function() {
this._diagnostics.push(clone);
}
- mergeRelationships(otherDiagnostic, parentHist, otherParentHist) {
- if (otherDiagnostic instanceof UnmergeableDiagnosticSet) {
- for (const subDiagnostic of otherDiagnostic) {
- this.mergeRelationships(subDiagnostic, parentHist, otherParentHist);
- }
- return;
- }
- for (const subDiagnostic of this) {
- if (!(subDiagnostic instanceof tr.v.d.RelatedHistogramMap) &&
- !(subDiagnostic instanceof tr.v.d.RelatedHistogramBreakdown)) {
- continue;
- }
- subDiagnostic.mergeRelationships(
- otherDiagnostic, parentHist, otherParentHist);
- }
- }
-
get length() {
return this._diagnostics.length;
}
« no previous file with comments | « tracing/tracing/value/diagnostics/tag_map.html ('k') | tracing/tracing/value/histogram.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698