Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tracing/tracing/metrics/v8/runtime_stats_metric.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/v8/runtime_stats_metric.html
diff --git a/tracing/tracing/metrics/v8/runtime_stats_metric.html b/tracing/tracing/metrics/v8/runtime_stats_metric.html
index 53aaacf3866551c0179d981bf7640ae26263dd09..5de680b91143666dadc97a6970f731abd2739b02 100644
--- a/tracing/tracing/metrics/v8/runtime_stats_metric.html
+++ b/tracing/tracing/metrics/v8/runtime_stats_metric.html
@@ -149,7 +149,6 @@ tr.exportTo('tr.metrics.v8', function() {
summaryOptions: SUMMARY_OPTIONS,
});
- // Record this histogram in RelatedHistogramMap.
if (durationRelatedHistsByGroupName.get(runtimeGroupName) ===
undefined) {
const durationHistogramMap = new tr.v.d.RelatedHistogramMap();
@@ -171,7 +170,6 @@ tr.exportTo('tr.metrics.v8', function() {
summaryOptions: SUMMARY_OPTIONS,
});
- // Record this histogram in RelatedHistogramMap.
if (countRelatedHistsByGroupName.get(runtimeGroupName) === undefined) {
const countHistogramMap = new tr.v.d.RelatedHistogramMap();
countHistogramMap.set(railStageName, countHistogram);
@@ -227,10 +225,9 @@ tr.exportTo('tr.metrics.v8', function() {
const durationRelatedHistsByGroupName = new Map();
const countRelatedHistsByGroupName = new Map();
- // Compute runtimeStats in each of the UE buckets. Also record the
- // histograms in RelatedHistogramMap. These histograms are added to the
- // corresponding histograms in the total bucket as a diagnostic. This keeps
- // the data grouped.
+ // Compute runtimeStats in each of the UE buckets. These histograms are
+ // added to the corresponding histograms in the total bucket as a
+ // diagnostic. This keeps the data grouped.
for (const [name, slicesUE] of v8SlicesBucketOnUEMap) {
const runtimeGroupCollection = new tr.e.v8.RuntimeStatsGroupCollection();
runtimeGroupCollection.addSlices(slicesUE);
« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | tracing/tracing/ui/side_panel/metrics_side_panel.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698