Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: tracing/tracing/metrics/system_health/long_tasks_metric_test.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/long_tasks_metric_test.html
diff --git a/tracing/tracing/metrics/system_health/long_tasks_metric_test.html b/tracing/tracing/metrics/system_health/long_tasks_metric_test.html
index 157c4a840824f1dac5874efc4cc898e7d9cc4ec1..a1abdcc81f8f56e7b18164fd5acf90c0dd06a4ba 100644
--- a/tracing/tracing/metrics/system_health/long_tasks_metric_test.html
+++ b/tracing/tracing/metrics/system_health/long_tasks_metric_test.html
@@ -72,37 +72,7 @@ tr.b.unittest.testSuite(function() {
assert.instanceOf(events, tr.v.d.RelatedEventSet);
assert.strictEqual(tr.b.getOnlyElement(events).title,
'foo');
- const breakdown = longTaskHist.diagnostics.get('category');
- assert.instanceOf(breakdown, tr.v.d.RelatedHistogramBreakdown);
- assert.lengthOf(breakdown, 4);
-
- let hist = breakdown.get('layout');
- assert.instanceOf(hist, tr.v.Histogram);
- assert.strictEqual(histograms.getHistogramNamed(hist.name), hist);
- assert.strictEqual(0, hist.name.indexOf(longTaskHist.name));
- assert.strictEqual(1, hist.numValues);
- assert.strictEqual(1, hist.allBins[1].count);
-
- hist = breakdown.get('gc');
- assert.instanceOf(hist, tr.v.Histogram);
- assert.strictEqual(histograms.getHistogramNamed(hist.name), hist);
- assert.strictEqual(0, hist.name.indexOf(longTaskHist.name));
- assert.strictEqual(1, hist.numValues);
- assert.strictEqual(1, hist.allBins[1].count);
-
- hist = breakdown.get('composite');
- assert.instanceOf(hist, tr.v.Histogram);
- assert.strictEqual(histograms.getHistogramNamed(hist.name), hist);
- assert.strictEqual(0, hist.name.indexOf(longTaskHist.name));
- assert.strictEqual(1, hist.numValues);
- assert.strictEqual(1, hist.allBins[1].count);
-
- hist = breakdown.get('imageDecode');
- assert.instanceOf(hist, tr.v.Histogram);
- assert.strictEqual(histograms.getHistogramNamed(hist.name), hist);
- assert.strictEqual(0, hist.name.indexOf(longTaskHist.name));
- assert.strictEqual(1, hist.numValues);
- assert.strictEqual(1, hist.allBins[1].count);
+ TODO;
});
});
</script>
« no previous file with comments | « tracing/tracing/metrics/system_health/long_tasks_metric.html ('k') | tracing/tracing/metrics/system_health/memory_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698