Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: docs/histogram-set-json-format.md

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/how-to-write-metrics.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/histogram-set-json-format.md
diff --git a/docs/histogram-set-json-format.md b/docs/histogram-set-json-format.md
index a4b59a4d1dc6385cb44cb803ed5056b02518916b..3b850aedb0e4bfc481c3411f27efdf8c2caa0c80 100644
--- a/docs/histogram-set-json-format.md
+++ b/docs/histogram-set-json-format.md
@@ -61,8 +61,7 @@ dictionary represents either a Histogram or a Diagnostic.
### Required fields
* `name`: any string
- * `guid`: string UUID, allows Histograms to reference other Histograms via
- RelatedHistogram Diagnostics
+ * `guid`: string UUID
* `unit`: underscore-separated string of 1 or 2 parts:
* The required unit base name must be one of
* ms
@@ -125,8 +124,7 @@ The only field that is required for all Diagnostics, `type`, must be one of
* `DateRange`
* `GenericSet`
* `RelatedEventSet`
- * `RelatedHistogramBreakdown`
- * `RelatedHistogramMap`
+ * `RelatedNameMap`
* `Scalar`
If a Diagnostic is in the root array of the JSON, then it is shared, so it may be
@@ -167,22 +165,12 @@ specific event or set of events in a trace.
* `events`: array of dictionaries containing `stableId`, `title`, `start`,
`duration` fields of Events
-### RelatedHistogramMap
-This allows metrics to annotate which Histograms are related to other
-Histograms, and annotate the nature of the relationship with a custom string
-name.
+### RelatedNameMap
- * `values`: dictionary mapping from custom string name to the related
- Histogram's string guid
+This is a Map from short descriptive names to full Histogram names.
-### RelatedHistogramBreakdown
-
-This allows metrics to explain the magnitudes of the samples in a Histogram
-collectively as composed of various categories.
-
- * `values`: dictionary mapping from custom string name to the related
- Histogram's string guid
+ * `names`: a dictionary mapping strings to strings containing Histogram names.
### Scalar
« no previous file with comments | « no previous file | docs/how-to-write-metrics.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698