Refactor Histogram relationship diagnostics.

tracing/tracing/value/histogram_set_unittest.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 from tracing.value import histogram
 from tracing.value import histogram_set
 from tracing.value.diagnostics import diagnostic_ref
 
 
 class HistogramSetUnittest(unittest.TestCase):
 
-  def testRelatedHistogramMap(self):
-    a = histogram.Histogram('a', 'unitless')
-    b = histogram.Histogram('b', 'unitless')
-    c = histogram.Histogram('c', 'unitless')
-    rhm = histogram.RelatedHistogramMap()
-    rhm.Set('y', b)
-    rhm.Set('z', c)
-    a.diagnostics['rhm'] = rhm
-
-    # Don't serialize c yet.
-    hists = histogram_set.HistogramSet([a, b])
-    hists2 = histogram_set.HistogramSet()
-    hists2.ImportDicts(hists.AsDicts())
-    hists2.ResolveRelatedHistograms()
-    a2 = hists2.GetHistogramsNamed('a')
-    self.assertEqual(len(a2), 1)
-    a2 = a2[0]
-    self.assertEqual(a2.guid, a.guid)
-    self.assertIsInstance(a2, histogram.Histogram)
-    self.assertIsNot(a2, a)
-    b2 = hists2.GetHistogramsNamed('b')
-    self.assertEqual(len(b2), 1)
-    b2 = b2[0]
-    self.assertEqual(b2.guid, b.guid)
-    self.assertIsInstance(b2, histogram.Histogram)
-    self.assertIsNot(b2, b)
-    rhm2 = a2.diagnostics['rhm']
-    self.assertIsInstance(rhm2, histogram.RelatedHistogramMap)
-    self.assertEqual(len(rhm2), 2)
-
-    # Assert that b and c are in a2's RelatedHistogramMap, rhm2.
-    self.assertIs(b2, rhm2.Get('y'))
-    self.assertIsInstance(rhm2.Get('z'), histogram.HistogramRef)
-
-    # Now serialize c and add it to hists2.
-    hists2.ImportDicts([c.AsDict()])
-    hists2.ResolveRelatedHistograms()
-
-    c2 = hists2.GetHistogramsNamed('c')
-    self.assertEqual(len(c2), 1)
-    c2 = c2[0]
-    self.assertEqual(c2.guid, c.guid)
-    self.assertIsNot(c2, c)
-
-    self.assertIs(b2, rhm2.Get('y'))
-    self.assertIs(c2, rhm2.Get('z'))
-
   def testGetSharedDiagnosticsOfType(self):
     d0 = histogram.GenericSet(['foo'])
     d1 = histogram.DateRange(0)
     hs = histogram_set.HistogramSet()
     hs.AddSharedDiagnostic('generic', d0)
     hs.AddSharedDiagnostic('generic', d1)
     diagnostics = hs.GetSharedDiagnosticsOfType(histogram.GenericSet)
     self.assertEqual(len(diagnostics), 1)
     self.assertIsInstance(diagnostics[0], histogram.GenericSet)
 
@@ skipping 69 matching lines @@
     diag0 = histogram.GenericSet(['shared0'])
     diag1 = histogram.GenericSet(['shared1'])
     hists.AddSharedDiagnostic('generic0', diag0)
 
     guid0 = diag0.guid
     guid1 = diag1.guid
 
     hists.ReplaceSharedDiagnostic(guid0, diag1)
 
     self.assertIsNotNone(hists.LookupDiagnostic(guid1))