Refactor Histogram relationship diagnostics.

tracing/tracing/value/histogram_set.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from tracing.value import histogram as histogram_module
 from tracing.value.diagnostics import all_diagnostics
 from tracing.value.diagnostics import diagnostic
 from tracing.value.diagnostics import diagnostic_ref
 
 class HistogramSet(object):
@@ skipping 33 matching lines @@
   def GetSharedDiagnosticsOfType(self, typ):
     return [d for d in self.shared_diagnostics if isinstance(d, typ)]
 
   def LookupHistogram(self, guid):
     return self._histograms_by_guid.get(guid)
 
   def LookupDiagnostic(self, guid):
     return self._shared_diagnostics_by_guid.get(guid)
 
   def ResolveRelatedHistograms(self):
-    histograms = self
-    def HandleDiagnosticMap(dm):
-      for diag in dm.itervalues():
-        if isinstance(diag, histogram_module.RelatedHistogramMap):
-          diag.Resolve(histograms)
-
     for hist in self:
       hist.diagnostics.ResolveSharedDiagnostics(self)
-      HandleDiagnosticMap(hist.diagnostics)
-      for dm in hist.nan_diagnostic_maps:
-        HandleDiagnosticMap(dm)
-      for hbin in hist.bins:
-        for dm in hbin.diagnostic_maps:
-          HandleDiagnosticMap(dm)
 
   def __len__(self):
     return len(self._histograms_by_guid)
 
   def __iter__(self):
     for hist in self._histograms_by_guid.itervalues():
       yield hist
 
   def ImportDicts(self, dicts):
     for d in dicts:
@@ skipping 12 matching lines @@
     return dcts
 
   def ReplaceSharedDiagnostic(self, old_guid, new_diagnostic):
     if not isinstance(new_diagnostic, diagnostic_ref.DiagnosticRef):
       self._shared_diagnostics_by_guid[new_diagnostic.guid] = new_diagnostic
 
     for hist in self:
       for name, diag in hist.diagnostics.iteritems():
         if diag.has_guid and diag.guid == old_guid:
           hist.diagnostics[name] = new_diagnostic