tracing/tracing/value/diagnostics/add_related_names_test.html - Issue 3009553002: Refactor Histogram relationship diagnostics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/value/diagnostics/add_related_names_test.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <!--

3 Copyright 2017 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.

6 -->

7

8 <link rel="import" href="/tracing/core/test_utils.html">

9 <link rel="import" href="/tracing/value/diagnostics/add_related_names.html">

10 <link rel="import" href="/tracing/value/histogram_set.html">

11

12 <script>

13 'use strict';

14

15 tr.b.unittest.testSuite(function() {

16 test('addRelatedNames', function() {

17 const histograms = new tr.v.HistogramSet();

18 const aHist = histograms.createHistogram('a', tr.b.Unit.byName.count, []);

19 const bHist = histograms.createHistogram('b', tr.b.Unit.byName.count, [], {

20 diagnostics: {rel: new tr.v.d.RelatedHistogramBreakdown()},

21 });

22 bHist.diagnostics.get('rel').set('A', aHist);

23 tr.v.d.addRelatedNames(histograms);

24 assert.isUndefined(aHist.diagnostics.get(

25 tr.v.d.RESERVED_NAMES.RELATED_NAMES));

26 assert.strictEqual(tr.b.getOnlyElement(bHist.diagnostics.get(

27 tr.v.d.RESERVED_NAMES.RELATED_NAMES)), aHist.name);

28 });

29 });

30 </script>

OLD	NEW