Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 300913002: DevTools: show HTTP headers of cached resources in network panel. (Closed)

Created:
6 years, 7 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: show HTTP headers of cached resources in network panel. Screenshot: http://picpaste.com/RaGXNCAZ.png BUG=91276 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175535

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Total comments: 4

Patch Set 3 : Addressed comments #

Patch Set 4 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M LayoutTests/http/tests/inspector/network/network-xhr-replay.html View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/inspector/network/network-xhr-replay-expected.txt View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/network/RequestHeadersView.js View 1 2 3 chunks +11 lines, -8 lines 0 comments Download
M Source/devtools/front_end/networkPanel.css View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 43 (0 generated)
eustas
6 years, 7 months ago (2014-05-28 11:34:51 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/300913002/diff/1/Source/devtools/front_end/networkPanel.css File Source/devtools/front_end/networkPanel.css (left): https://chromiumcodereview.appspot.com/300913002/diff/1/Source/devtools/front_end/networkPanel.css#oldcode142 Source/devtools/front_end/networkPanel.css:142: .resource-headers-view .outline-disclosure li .status-from-cache { This stile is still ...
6 years, 6 months ago (2014-05-28 17:34:44 UTC) #2
vsevik
What kind of headers will we show in this case? I would assume that like ...
6 years, 6 months ago (2014-05-28 17:40:38 UTC) #3
eustas
On 2014/05/28 17:40:38, vsevik wrote: > What kind of headers will we show in this ...
6 years, 6 months ago (2014-05-29 07:10:26 UTC) #4
eustas
https://codereview.chromium.org/300913002/diff/1/Source/devtools/front_end/networkPanel.css File Source/devtools/front_end/networkPanel.css (left): https://codereview.chromium.org/300913002/diff/1/Source/devtools/front_end/networkPanel.css#oldcode142 Source/devtools/front_end/networkPanel.css:142: .resource-headers-view .outline-disclosure li .status-from-cache { On 2014/05/28 17:34:44, vsevik ...
6 years, 6 months ago (2014-05-29 09:01:33 UTC) #5
aandrey
On 2014/05/29 07:10:26, eustas wrote: > On 2014/05/28 17:40:38, vsevik wrote: > > What kind ...
6 years, 6 months ago (2014-05-29 09:21:07 UTC) #6
eustas
Ping
6 years, 6 months ago (2014-06-02 11:49:38 UTC) #7
vsevik
lgtm https://chromiumcodereview.appspot.com/300913002/diff/10001/Source/devtools/front_end/network/RequestHeadersView.js File Source/devtools/front_end/network/RequestHeadersView.js (right): https://chromiumcodereview.appspot.com/300913002/diff/10001/Source/devtools/front_end/network/RequestHeadersView.js#newcode438 Source/devtools/front_end/network/RequestHeadersView.js:438: var showCaution = provisionalHeaders && !this._request.cached; I think ...
6 years, 6 months ago (2014-06-02 14:49:27 UTC) #8
eustas
https://codereview.chromium.org/300913002/diff/10001/Source/devtools/front_end/network/RequestHeadersView.js File Source/devtools/front_end/network/RequestHeadersView.js (right): https://codereview.chromium.org/300913002/diff/10001/Source/devtools/front_end/network/RequestHeadersView.js#newcode438 Source/devtools/front_end/network/RequestHeadersView.js:438: var showCaution = provisionalHeaders && !this._request.cached; On 2014/06/02 14:49:27, ...
6 years, 6 months ago (2014-06-03 05:56:42 UTC) #9
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-03 05:56:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/30001
6 years, 6 months ago (2014-06-03 05:57:25 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-03 07:21:36 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 07:45:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10488)
6 years, 6 months ago (2014-06-03 07:45:44 UTC) #14
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-03 08:15:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/30001
6 years, 6 months ago (2014-06-03 08:15:48 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-03 09:33:02 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 10:15:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10029)
6 years, 6 months ago (2014-06-03 10:15:20 UTC) #19
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-03 11:40:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/30001
6 years, 6 months ago (2014-06-03 11:40:53 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-03 12:47:04 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 13:27:22 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10537)
6 years, 6 months ago (2014-06-03 13:27:25 UTC) #24
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-03 14:06:59 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/30001
6 years, 6 months ago (2014-06-03 14:07:41 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-03 14:50:54 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 15:28:25 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10085)
6 years, 6 months ago (2014-06-03 15:28:26 UTC) #29
eustas
PTAL
6 years, 6 months ago (2014-06-03 16:02:13 UTC) #30
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-04 04:47:02 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/50001
6 years, 6 months ago (2014-06-04 04:47:25 UTC) #32
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-04 05:23:50 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 05:31:00 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10213)
6 years, 6 months ago (2014-06-04 05:31:01 UTC) #35
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-04 13:00:30 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/50001
6 years, 6 months ago (2014-06-04 13:01:48 UTC) #37
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 14:19:06 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 15:46:00 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/10974)
6 years, 6 months ago (2014-06-04 15:46:01 UTC) #40
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-05 04:45:42 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/300913002/50001
6 years, 6 months ago (2014-06-05 04:46:32 UTC) #42
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 05:47:33 UTC) #43
Message was sent while issue was closed.
Change committed as 175535

Powered by Google App Engine
This is Rietveld 408576698