Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/value/trace_unittest.py ('k') | tracing/tracing/metrics/metric_map_function.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/telemetry/telemetry/web_perf/timeline_based_measurement.py b/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 8345896527f1fa4dca1da70b40d69ff3a3921862..87a51f90685daad8473325b4a8dc3e46f081511c 100644
--- a/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -279,12 +279,7 @@
"""Collect all possible metrics and added them to results."""
platform.tracing_controller.telemetry_info = results.telemetry_info
trace_result = platform.tracing_controller.StopTracing()
- trace_value = trace.TraceValue(
- results.current_page, trace_result,
- file_path=results.telemetry_info.trace_local_path,
- remote_path=results.telemetry_info.trace_remote_path,
- upload_bucket=results.telemetry_info.upload_bucket,
- cloud_url=results.telemetry_info.trace_remote_url)
+ trace_value = trace.TraceValue(results.current_page, trace_result)
results.AddValue(trace_value)
try:
@@ -309,12 +304,7 @@
"""Clean up after running the story."""
if platform.tracing_controller.is_tracing_running:
trace_result = platform.tracing_controller.StopTracing()
- trace_value = trace.TraceValue(
- results.current_page, trace_result,
- file_path=results.telemetry_info.trace_local_path,
- remote_path=results.telemetry_info.trace_remote_path,
- upload_bucket=results.telemetry_info.upload_bucket,
- cloud_url=results.telemetry_info.trace_remote_url)
+ trace_value = trace.TraceValue(results.current_page, trace_result)
results.AddValue(trace_value)
def _ComputeTimelineBasedMetrics(self, results, trace_value):
@@ -326,7 +316,7 @@
start = time.time()
mre_result = metric_runner.RunMetric(
trace_value.filename, metrics, extra_import_options,
- report_progress=False, canonical_url=results.telemetry_info.trace_url)
+ report_progress=False)
logging.warning('Processing resulting traces took %.3f seconds' % (
time.time() - start))
page = results.current_page
« no previous file with comments | « telemetry/telemetry/value/trace_unittest.py ('k') | tracing/tracing/metrics/metric_map_function.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698