telemetry/telemetry/internal/story_runner.py - Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/story_runner.py

Issue 3007313002: Revert of Plumb trace canonicalUrl through TelemetryInfo. (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/story_runner.py

diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py

index d8ecafeb2d5c56a7e2bba370d2272e100bd86538..1bf512d431384045bd08e8b972b4f88f3ec01d30 100644

--- a/telemetry/telemetry/internal/story_runner.py

+++ b/telemetry/telemetry/internal/story_runner.py

@@ -352,8 +352,11 @@

try:

if finder_options.upload_results:

- results.UploadTraceFilesToCloud()

- results.UploadProfilingFilesToCloud()

+ bucket = finder_options.upload_bucket

+ if bucket in cloud_storage.BUCKET_ALIASES:

+ bucket = cloud_storage.BUCKET_ALIASES[bucket]

+ results.UploadTraceFilesToCloud(bucket)

+ results.UploadProfilingFilesToCloud(bucket)

finally:

duration = time.time() - start

results.AddSummaryValue(scalar.ScalarValue(