Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tracing/tracing/metrics/metric_map_function.html

Issue 3007063002: Plumb trace canonicalUrl through TelemetryInfo. (Closed)
Patch Set: fix trace_unittest Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/metric_map_function.html
diff --git a/tracing/tracing/metrics/metric_map_function.html b/tracing/tracing/metrics/metric_map_function.html
index 8ba8196edd01e6f630130f37c4071e82114b4aae..4f0ed8441a7bb03650c3a30414575c0f0b830de3 100644
--- a/tracing/tracing/metrics/metric_map_function.html
+++ b/tracing/tracing/metrics/metric_map_function.html
@@ -70,6 +70,13 @@ tr.exportTo('tr.metrics', function() {
for (const metadata of model.metadata) {
if (!metadata.value || !metadata.value.telemetry) continue;
+ const traceUrls = metadata.value.telemetry[
+ tr.v.d.RESERVED_NAMES.TRACE_URLS];
+ if (traceUrls && model.canonicalUrl !== traceUrls[0]) {
+ throw new Error(`canonicalUrl "${model.canonicalUrl}" != ` +
+ `traceUrl "${traceUrls[0]}"`);
+ }
+
for (const [name, value] of Object.entries(metadata.value.telemetry)) {
const type = tr.v.d.RESERVED_NAMES_TO_TYPES.get(name);
if (type === undefined) {
« no previous file with comments | « telemetry/telemetry/web_perf/timeline_based_measurement.py ('k') | tracing/tracing/metrics/metric_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698