Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: telemetry/telemetry/internal/story_runner.py

Issue 3007063002: Plumb trace canonicalUrl through TelemetryInfo. (Closed)
Patch Set: fix trace_unittest Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/results/results_options.py ('k') | telemetry/telemetry/value/trace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/story_runner.py
diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py
index 1bf512d431384045bd08e8b972b4f88f3ec01d30..d8ecafeb2d5c56a7e2bba370d2272e100bd86538 100644
--- a/telemetry/telemetry/internal/story_runner.py
+++ b/telemetry/telemetry/internal/story_runner.py
@@ -352,11 +352,8 @@ def RunBenchmark(benchmark, finder_options):
try:
if finder_options.upload_results:
- bucket = finder_options.upload_bucket
- if bucket in cloud_storage.BUCKET_ALIASES:
- bucket = cloud_storage.BUCKET_ALIASES[bucket]
- results.UploadTraceFilesToCloud(bucket)
- results.UploadProfilingFilesToCloud(bucket)
+ results.UploadTraceFilesToCloud()
+ results.UploadProfilingFilesToCloud()
finally:
duration = time.time() - start
results.AddSummaryValue(scalar.ScalarValue(
« no previous file with comments | « telemetry/telemetry/internal/results/results_options.py ('k') | telemetry/telemetry/value/trace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698