Plumb trace canonicalUrl through TelemetryInfo.

telemetry/telemetry/value/trace.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import datetime
 import logging
 import os
-import random
 import shutil
 import sys
 import tempfile
 
 from py_utils import cloud_storage  # pylint: disable=import-error
 
 from telemetry.internal.util import file_handle
 from telemetry.timeline import trace_data as trace_data_module
 from telemetry import value as value_module
 from tracing.trace_data import trace_data as trace_data_module
 
 
 class TraceValue(value_module.Value):
-  def __init__(self, page, trace_data, important=False, description=None):
+  def __init__(self, page, trace_data, important=False, description=None,
+               file_path=None, remote_path=None, upload_bucket=None,
+               cloud_url=None):
     """A value that contains a TraceData object and knows how to
     output it.
 
     Adding TraceValues and outputting as JSON will produce a directory full of
     HTML files called trace_files. Outputting as chart JSON will also produce
     an index, files.html, linking to each of these files.
     """
     super(TraceValue, self).__init__(
         page, name='trace', units='', important=important,
         description=description, tir_label=None, grouping_keys=None)
     self._temp_file = self._GetTempFileHandle(trace_data)
-    self._cloud_url = None
+    self._file_path = file_path
+    self._remote_path = remote_path
+    self._upload_bucket = upload_bucket
+    self._cloud_url = cloud_url
     self._serialized_file_handle = None
 
   @property
   def value(self):
     if self._cloud_url:
       return self._cloud_url
     elif self._serialized_file_handle:
       return self._serialized_file_handle.GetAbsPath()
 
   def _GetTraceParts(self, trace_data):
@@ skipping 70 matching lines @@
   def AsDict(self):
     if self._temp_file is None:
       raise ValueError('Tried to serialize TraceValue without tempfile.')
     d = super(TraceValue, self).AsDict()
     if self._serialized_file_handle:
       d['file_id'] = self._serialized_file_handle.id
     if self._cloud_url:
       d['cloud_url'] = self._cloud_url
     return d
 
-  def Serialize(self, dir_path):
-    if self._temp_file is None:
+  def Serialize(self):
+    if self._temp_file is None or self._file_path is None:
       raise ValueError('Tried to serialize nonexistent trace.')
-    if self.page:
-      file_name = self.page.file_safe_name
-    else:
-      file_name = ''
-    file_name += str(self._temp_file.id)
-    file_name += datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S')
-    file_name += self._temp_file.extension
-    file_path = os.path.abspath(os.path.join(dir_path, file_name))
-    shutil.copy(self._temp_file.GetAbsPath(), file_path)
-    self._serialized_file_handle = file_handle.FromFilePath(file_path)
+    shutil.copy(self._temp_file.GetAbsPath(), self._file_path)
+    self._serialized_file_handle = file_handle.FromFilePath(self._file_path)
     return self._serialized_file_handle
 
-  def UploadToCloud(self, bucket):
+  def UploadToCloud(self):
     if self._temp_file is None:
       raise ValueError('Tried to upload nonexistent trace to Cloud Storage.')
     try:
       if self._serialized_file_handle:
         fh = self._serialized_file_handle
       else:
         fh = self._temp_file
-      remote_path = ('trace-file-id_%s-%s-%d%s' % (
-          fh.id,
-          datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S'),
-          random.randint(1, 100000),
-          fh.extension))
-      self._cloud_url = cloud_storage.Insert(
-          bucket, remote_path, fh.GetAbsPath())
+      cloud_storage.Insert(
+          self._upload_bucket, self._remote_path, fh.GetAbsPath())
       sys.stderr.write(
           'View generated trace files online at %s for story %s\n' %
           (self._cloud_url, self.page.name if self.page else 'unknown'))
       return self._cloud_url
     except cloud_storage.PermissionError as e:
       logging.error('Cannot upload trace files to cloud storage due to '
                     ' permission error: %s' % e.message)