Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 3005233002: DEMO: Add VideoProcessorIntegrationTest for MediaCodec implementations. (Closed)

Created:
3 years, 3 months ago by kjellander_webrtc
Modified:
3 years, 2 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

DEMO: Add VideoProcessorIntegrationTest for MediaCodec implementations. * Add VideoProcessorIntegrationTestMediaCodec tests, including a standard foreman test and a forced SW fallback test. * Morph PlotVideoProcessorIntegrationTest into VideoProcessorIntegrationTestParameterized. This test is intended to be patched locally, depending on what metric is of interest. It is run on the bots to ensure that it doesn't break. * Remove the plot_videoprocessor_integrationtest binary. The test above is instead moved to the modules_tests binary. BUG=webrtc:6634 patch from issue 3011043002 at patchset 120001 (http://crrev.com/3011043002#ps120001)

Patch Set 1 : Pristine patch #

Patch Set 2 : Putting the dep where it's used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -251 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 chunks +33 lines, -109 lines 0 comments Download
D webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 4 chunks +1 line, -6 lines 0 comments Download
A webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_parameterized.cc View 3 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kjellander_webrtc
3 years, 3 months ago (2017-09-07 09:38:36 UTC) #1
PS#2 reverts the change in webrtc/modules/BUILD.gn and adds 
"../../sdk/android:libjingle_peerconnection_java" to
webrtc/modules/video_coding/BUILD.gn where it was claimed not to work.

Powered by Google App Engine
This is Rietveld 408576698