Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Side by Side Diff: telemetry/telemetry/internal/results/page_test_results_unittest.py

Issue 3004383002: Remove JsonOutputFormatter from telemetry. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 7
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry import story 9 from telemetry import story
10 from telemetry.internal.results import base_test_results_unittest 10 from telemetry.internal.results import base_test_results_unittest
11 from telemetry.internal.results import chart_json_output_formatter 11 from telemetry.internal.results import chart_json_output_formatter
12 from telemetry.internal.results import json_output_formatter 12 from telemetry.internal.results import html_output_formatter
13 from telemetry.internal.results import page_test_results 13 from telemetry.internal.results import page_test_results
14 from telemetry import page as page_module 14 from telemetry import page as page_module
15 from telemetry.testing import stream 15 from telemetry.testing import stream
16 from telemetry.value import failure 16 from telemetry.value import failure
17 from telemetry.value import histogram 17 from telemetry.value import histogram
18 from telemetry.value import improvement_direction 18 from telemetry.value import improvement_direction
19 from telemetry.value import scalar 19 from telemetry.value import scalar
20 from telemetry.value import skip 20 from telemetry.value import skip
21 from telemetry.value import trace 21 from telemetry.value import trace
22 from tracing.trace_data import trace_data 22 from tracing.trace_data import trace_data
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 self.assertFalse(results.FindAllTraceValues()) 401 self.assertFalse(results.FindAllTraceValues())
402 402
403 def testPrintSummaryDisabledResults(self): 403 def testPrintSummaryDisabledResults(self):
404 output_stream = stream.TestOutputStream() 404 output_stream = stream.TestOutputStream()
405 output_formatters = [] 405 output_formatters = []
406 benchmark_metadata = benchmark.BenchmarkMetadata( 406 benchmark_metadata = benchmark.BenchmarkMetadata(
407 'benchmark_name', 'benchmark_description') 407 'benchmark_name', 'benchmark_description')
408 output_formatters.append( 408 output_formatters.append(
409 chart_json_output_formatter.ChartJsonOutputFormatter( 409 chart_json_output_formatter.ChartJsonOutputFormatter(
410 output_stream, benchmark_metadata)) 410 output_stream, benchmark_metadata))
411 output_formatters.append(json_output_formatter.JsonOutputFormatter( 411 output_formatters.append(html_output_formatter.HtmlOutputFormatter(
412 output_stream, benchmark_metadata)) 412 output_stream, benchmark_metadata, True))
413 results = page_test_results.PageTestResults( 413 results = page_test_results.PageTestResults(
414 output_formatters=output_formatters, benchmark_enabled=False) 414 output_formatters=output_formatters, benchmark_enabled=False)
415 results.PrintSummary() 415 results.PrintSummary()
416 self.assertEquals( 416 self.assertEquals(
417 output_stream.output_data, 417 output_stream.output_data,
418 '{\n \"enabled\": false,\n ' + 418 '{\n \"enabled\": false,\n ' +
419 '\"benchmark_name\": \"benchmark_name\"\n}\n') 419 '\"benchmark_name\": \"benchmark_name\"\n}\n')
420 420
421 def testAddSharedDiagnostic(self): 421 def testAddSharedDiagnostic(self):
422 results = page_test_results.PageTestResults() 422 results = page_test_results.PageTestResults()
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 self.pages[0], 'b', 'seconds', 8, 607 self.pages[0], 'b', 'seconds', 8,
608 improvement_direction=improvement_direction.UP)) 608 improvement_direction=improvement_direction.UP))
609 results.AddValue(skip_value) 609 results.AddValue(skip_value)
610 results.DidRunPage(self.pages[0]) 610 results.DidRunPage(self.pages[0])
611 results.PrintSummary() 611 results.PrintSummary()
612 612
613 # Although predicate says only accept value with named 'a', skip value is 613 # Although predicate says only accept value with named 'a', skip value is
614 # added anyway. 614 # added anyway.
615 self.assertEquals(len(results.all_page_specific_values), 1) 615 self.assertEquals(len(results.all_page_specific_values), 1)
616 self.assertIn(skip_value, results.all_page_specific_values) 616 self.assertIn(skip_value, results.all_page_specific_values)
OLDNEW
« no previous file with comments | « telemetry/telemetry/internal/results/page_test_results.py ('k') | telemetry/telemetry/internal/results/results_options.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698