tracing/tracing/value/ui/breakdown_span_test.html - Issue 3002973002: Refactor diagnostic spans to share a polymer behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/value/ui/breakdown_span_test.html

Issue 3002973002: Refactor diagnostic spans to share a polymer behavior. (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/value/ui/breakdown_span_test.html

diff --git a/tracing/tracing/value/ui/breakdown_span_test.html b/tracing/tracing/value/ui/breakdown_span_test.html

index b67da23d634bf7a3212470d18034a160de0a3a70..60190ea61965a8dc65ece22382b09e43a58d14c5 100644

--- a/tracing/tracing/value/ui/breakdown_span_test.html

+++ b/tracing/tracing/value/ui/breakdown_span_test.html

@@ -37,8 +37,8 @@ tr.b.unittest.testSuite(function() {

bar.addSample(i);

}

- const span = tr.v.ui.createDiagnosticSpan(

- breakdown, new tr.v.Histogram('', tr.b.Unit.byName.timeDurationInMs));

+ const span = tr.v.ui.createDiagnosticSpan(breakdown, '', new tr.v.Histogram(

+ '', tr.b.Unit.byName.timeDurationInMs));

assert.strictEqual('TR-V-UI-BREAKDOWN-SPAN', span.tagName);

this.addHTMLOutput(span);

assert.isDefined(tr.ui.b.findDeepElementMatchingPredicate(