telemetry/telemetry/story/expectations.py - Issue 3001873002: [Telemetry] Add CanRunOnPlatform to story_runner and benchmark class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/story/expectations.py

Issue 3001873002: [Telemetry] Add CanRunOnPlatform to story_runner and benchmark class. (Closed)

Patch Set: Charlies comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/story/expectations.py

diff --git a/telemetry/telemetry/story/expectations.py b/telemetry/telemetry/story/expectations.py

index c57d64d4e797ae48d4b6abfb8cfe11789ccc65bb..6db8d90526ce338ef8be92d0764297e4e9133a16 100644

--- a/telemetry/telemetry/story/expectations.py

+++ b/telemetry/telemetry/story/expectations.py

@@ -135,6 +135,9 @@ class StoryExpectations(object):

return None

+# TODO(rnephew): Since TestConditions are being used for more than

+# just story expectations now, this should be decoupled and refactored

+# to be clearer.

class _TestCondition(object):

def ShouldDisable(self, platform, finder_options):

raise NotImplementedError

« no previous file with comments | « telemetry/telemetry/internal/story_runner_unittest.py ('k') | no next file » | no next file with comments »