Copy libhello_fuchsia.so into root output directory

Copy libhello_fuchsia.so into root output directory

R=mcgrathr@chromium.org, zra@google.com

https://fuchsia-review.googlesource.com/37541 enables building all
shared library in Fuchsia using the shared toolchain, but that means
libhello_fuchsia.so will end up in a different directory, so we need
to copy it to root output directory afterwards.
Committed: https://github.com/dart-lang/sdk/commit/0908a611f41081d6ada5e3ba80f0137621b9da7c

[phosek, 2017-08-12 07:07:45]

Description was changed from

==========
Copy libhello_fuchsia.so into root output directory

https://fuchsia-review.googlesource.com/37541 enables building all
shared library in Fuchsia using the shared toolchain, but that means
libhello_fuchsia.so will end up in a different directory, so we need
to copy it to root output directory afterwards.
==========

to

==========
Copy libhello_fuchsia.so into root output directory

https://fuchsia-review.googlesource.com/37541 enables building all
shared library in Fuchsia using the shared toolchain, but that means
libhello_fuchsia.so will end up in a different directory, so we need
to copy it to root output directory afterwards.
==========

[phosek, 2017-08-12 07:07:45]

phosek@google.com changed reviewers:
+ rmacnak@google.com, zra@google.com

[phosek, 2017-08-14 01:38:17]

phosek@google.com changed reviewers:
+ phosek@google.com

[Roland McGrath, 2017-08-14 01:43:47]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2017-08-14 01:43:47]

lgtm

[zra, 2017-08-14 20:05:00]

lgtm

I'll land the CL, and respond here again when it rolls into Fuchsia.

[Petr Hosek, 2017-08-14 20:09:51]

On 2017/08/14 20:05:00, zra wrote:
> lgtm
> 
> I'll land the CL, and respond here again when it rolls into Fuchsia.

Let me know when it lands. When rolling this change into Fuchsia, it has to land
together with https://fuchsia-review.googlesource.com/c/49790 so should use a
topic for that roll.

[zra, 2017-08-14 21:03:41]

On 2017/08/14 20:09:51, Petr Hosek wrote:
> On 2017/08/14 20:05:00, zra wrote:
> > lgtm
> > 
> > I'll land the CL, and respond here again when it rolls into Fuchsia.
> 
> Let me know when it lands. When rolling this change into Fuchsia, it has to
land
> together with https://fuchsia-review.googlesource.com/c/49790 so should use a
> topic for that roll.

Ah, okay. Even though Dart is pinned, I would prefer it if we don't break the
Dart build at head.

Could we instead do the following?
1. Remove libhello_fuchsia.so from the image:
https://fuchsia.googlesource.com/packages/+/master/gn/dart#30
2. Land this CL with the copy rule commented out.
3. Roll Dart forward
4. Land 49790, etc.
5. Add libhello_fuchsia.so back to the image.

[Petr Hosek, 2017-08-14 22:14:32]

On 2017/08/14 21:03:41, zra wrote:
> On 2017/08/14 20:09:51, Petr Hosek wrote:
> > On 2017/08/14 20:05:00, zra wrote:
> > > lgtm
> > > 
> > > I'll land the CL, and respond here again when it rolls into Fuchsia.
> > 
> > Let me know when it lands. When rolling this change into Fuchsia, it has to
> land
> > together with https://fuchsia-review.googlesource.com/c/49790 so should use
a
> > topic for that roll.
> 
> Ah, okay. Even though Dart is pinned, I would prefer it if we don't break the
> Dart build at head.
> 
> Could we instead do the following?
> 1. Remove libhello_fuchsia.so from the image:
> https://fuchsia.googlesource.com/packages/+/master/gn/dart#30
> 2. Land this CL with the copy rule commented out.
> 3. Roll Dart forward
> 4. Land 49790, etc.
> 5. Add libhello_fuchsia.so back to the image.

I have commented out the copy rule.

[zra, 2017-08-14 22:24:28]

Description was changed from

==========
Copy libhello_fuchsia.so into root output directory

https://fuchsia-review.googlesource.com/37541 enables building all
shared library in Fuchsia using the shared toolchain, but that means
libhello_fuchsia.so will end up in a different directory, so we need
to copy it to root output directory afterwards.
==========

to

==========
Copy libhello_fuchsia.so into root output directory

R=mcgrathr@chromium.org, zra@google.com

https://fuchsia-review.googlesource.com/37541 enables building all
shared library in Fuchsia using the shared toolchain, but that means
libhello_fuchsia.so will end up in a different directory, so we need
to copy it to root output directory afterwards.
Committed:
https://github.com/dart-lang/sdk/commit/0908a611f41081d6ada5e3ba80f0137621b9da7c
==========

[zra, 2017-08-14 22:24:32]

Committed patchset #2 (id:20001) manually as
0908a611f41081d6ada5e3ba80f0137621b9da7c (presubmit successful).

[zra, 2017-08-14 22:33:56]

On 2017/08/14 22:24:32, zra wrote:
> Committed patchset #2 (id:20001) manually as
> 0908a611f41081d6ada5e3ba80f0137621b9da7c (presubmit successful).

Taking a look at our buildbots, I expect to be able to do a roll of this change
into Fuchsia tomorrow morning at the earliest.

[Petr Hosek, 2017-08-14 22:34:55]

On 2017/08/14 22:33:56, zra wrote:
> On 2017/08/14 22:24:32, zra wrote:
> > Committed patchset #2 (id:20001) manually as
> > 0908a611f41081d6ada5e3ba80f0137621b9da7c (presubmit successful).
> 
> Taking a look at our buildbots, I expect to be able to do a roll of this
change
> into Fuchsia tomorrow morning at the earliest.

OK, we'll wait until then before landing our changes, thanks.

[zra, 2017-08-15 16:24:43]

On 2017/08/14 22:34:55, Petr Hosek wrote:
> On 2017/08/14 22:33:56, zra wrote:
> > On 2017/08/14 22:24:32, zra wrote:
> > > Committed patchset #2 (id:20001) manually as
> > > 0908a611f41081d6ada5e3ba80f0137621b9da7c (presubmit successful).
> > 
> > Taking a look at our buildbots, I expect to be able to do a roll of this
> change
> > into Fuchsia tomorrow morning at the earliest.
> 
> OK, we'll wait until then before landing our changes, thanks.

I have rolled Dart in Fuchsia past this change.