Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: tracing/tracing/value/histogram_parameter_collector.html

Issue 2999863002: Results.html: record maximum Histogram.numValues in google analytics. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/value/ui/timings.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_parameter_collector.html
diff --git a/tracing/tracing/value/histogram_parameter_collector.html b/tracing/tracing/value/histogram_parameter_collector.html
index a6e05e6fc26452353c6f3bf6ae76effc894916df..639c5b8ca55f15649c824e74fd3900234ca63e2b 100644
--- a/tracing/tracing/value/histogram_parameter_collector.html
+++ b/tracing/tracing/value/histogram_parameter_collector.html
@@ -5,6 +5,7 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
+<link rel="import" href="/tracing/base/timing.html">
<link rel="import" href="/tracing/value/histogram_grouping.html">
<link rel="import" href="/tracing/value/histogram_set.html">
@@ -57,7 +58,10 @@ tr.exportTo('tr.v', function() {
process(histograms) {
const allStoryTags = new Set();
+ let maxSampleCount = 0;
for (const hist of histograms) {
+ maxSampleCount = Math.max(maxSampleCount, hist.numValues);
+
for (const statName of hist.statisticsNames) {
this.statisticNames_.add(statName);
}
@@ -123,6 +127,8 @@ tr.exportTo('tr.v', function() {
this.keysToValues_.set(groupingKey, new Set([callback(hist)]));
}
}
+ tr.b.Timing.instant(
+ 'HistogramParameterCollector', 'maxSampleCount', maxSampleCount);
for (const tagGrouping of tr.v.HistogramGrouping.buildFromTags(
allStoryTags, tr.v.d.RESERVED_NAMES.STORY_TAGS)) {
« no previous file with comments | « no previous file | tracing/tracing/value/ui/timings.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698