Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2999173002: Pinpoint - Update job creation page for new params. (Closed)

Created:
3 years, 4 months ago by shatch
Modified:
3 years, 4 months ago
Reviewers:
dtu
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Pinpoint - Update job creation page for new params. Mostly used for testing, would like it to work. BUG=catapult:#3334 Review-Url: https://codereview.chromium.org/2999173002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8995f3ead39ec47a5cd96607bbefde9eba8b2b72

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M dashboard/dashboard/pinpoint/elements/new-job-dialog.html View 1 2 6 chunks +20 lines, -8 lines 0 comments Download
M dashboard/dashboard/pinpoint/elements/new-job-dialog-test.html View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
shatch
https://codereview.chromium.org/2999173002/diff/40001/dashboard/dashboard/pinpoint/elements/new-job-dialog.html File dashboard/dashboard/pinpoint/elements/new-job-dialog.html (right): https://codereview.chromium.org/2999173002/diff/40001/dashboard/dashboard/pinpoint/elements/new-job-dialog.html#newcode155 dashboard/dashboard/pinpoint/elements/new-job-dialog.html:155: dimensions: JSON.stringify([ Not really sure how to expose these, ...
3 years, 4 months ago (2017-08-17 17:15:58 UTC) #2
dtu
lgtm
3 years, 4 months ago (2017-08-17 18:57:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2999173002/60001
3 years, 4 months ago (2017-08-17 20:23:35 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 20:25:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698