Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc

Issue 2999073002: Tweaked version of BBR for WebRTC. (Closed)
Patch Set: Updated according to comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc
index a8e76e127e31645b24fb10ad699478b937148ee5..5cf08d4111e71ab6b6345cf9e20e19e90ead38f9 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/min_rtt_filter_unittest.cc
@@ -18,28 +18,24 @@ namespace bwe {
TEST(MinRttFilterTest, InitializationCheck) {
MinRttFilter min_rtt_filter;
EXPECT_FALSE(min_rtt_filter.min_rtt_ms());
- EXPECT_EQ(min_rtt_filter.discovery_time(), 0);
}
TEST(MinRttFilterTest, AddRttSample) {
MinRttFilter min_rtt_filter;
min_rtt_filter.AddRttSample(120, 5);
- EXPECT_EQ(min_rtt_filter.min_rtt_ms(), 120);
- EXPECT_EQ(min_rtt_filter.discovery_time(), 5);
+ EXPECT_EQ(*min_rtt_filter.min_rtt_ms(), 120);
min_rtt_filter.AddRttSample(121, 6);
- EXPECT_EQ(min_rtt_filter.discovery_time(), 5);
min_rtt_filter.AddRttSample(119, 7);
- EXPECT_EQ(min_rtt_filter.discovery_time(), 7);
min_rtt_filter.AddRttSample(140, 10007);
- EXPECT_EQ(min_rtt_filter.discovery_time(), 10007);
- EXPECT_EQ(min_rtt_filter.min_rtt_ms(), 140);
+ EXPECT_EQ(*min_rtt_filter.min_rtt_ms(), 119);
}
TEST(MinRttFilterTest, MinRttExpired) {
MinRttFilter min_rtt_filter;
- min_rtt_filter.AddRttSample(120, 5);
- EXPECT_EQ(min_rtt_filter.MinRttExpired(10006), true);
- EXPECT_EQ(min_rtt_filter.MinRttExpired(10), false);
+ for (int i = 1; i <= 25; i++)
+ min_rtt_filter.AddRttSample(i, i);
+ EXPECT_EQ(min_rtt_filter.MinRttExpired(25), true);
+ EXPECT_EQ(min_rtt_filter.MinRttExpired(24), false);
}
} // namespace bwe
} // namespace testing

Powered by Google App Engine
This is Rietveld 408576698