Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc

Issue 2999073002: Tweaked version of BBR for WebRTC. (Closed)
Patch Set: Updated according to comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc b/webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc
index b3cb98d4e875ce1b7df155d460e105d913e3ab8f..92d5a55b4d39f5f9ca287926e62377e3e4fa31f6 100644
--- a/webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc
+++ b/webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc
@@ -122,9 +122,64 @@ TEST_P(BweSimulation, Choke1000kbps500kbps1000kbps) {
RunFor(60 * 1000);
}
+TEST_P(BweSimulation, SimulationsCompiled) {
+ AdaptiveVideoSource source(0, 30, 300, 0, 0);
+ PacedVideoSender sender(&uplink_, &source, GetParam());
+ int zero = 0;
+ // CreateFlowIds() doesn't support passing int as a flow id, so we pass
+ // pointer instead.
+ DelayFilter delay(&uplink_, CreateFlowIds(&zero, 1));
+ delay.SetOneWayDelayMs(100);
+ ChokeFilter filter(&uplink_, 0);
+ RateCounterFilter counter(&uplink_, 0, "Receiver", bwe_names[GetParam()]);
+ PacketReceiver receiver(&uplink_, 0, GetParam(), true, true);
+ filter.set_max_delay_ms(500);
+ filter.set_capacity_kbps(1000);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(500);
+ RunFor(50 * 1000);
+ filter.set_capacity_kbps(1000);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(200);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(50);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(200);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(500);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(300);
+ RunFor(60 * 1000);
+ filter.set_capacity_kbps(1000);
+ RunFor(60 * 1000);
+ const int kStartingCapacityKbps = 150;
+ const int kEndingCapacityKbps = 1500;
+ const int kStepKbps = 5;
+ const int kStepTimeMs = 1000;
+ for (int i = kStartingCapacityKbps; i <= kEndingCapacityKbps;
+ i += kStepKbps) {
+ filter.set_capacity_kbps(i);
+ RunFor(kStepTimeMs);
+ }
+ for (int i = kEndingCapacityKbps; i >= kStartingCapacityKbps;
+ i -= kStepKbps) {
+ filter.set_capacity_kbps(i);
+ RunFor(kStepTimeMs);
+ }
+ filter.set_capacity_kbps(150);
+ RunFor(120 * 1000);
+ filter.set_capacity_kbps(500);
+ RunFor(60 * 1000);
+}
+
TEST_P(BweSimulation, PacerChoke1000kbps500kbps1000kbps) {
AdaptiveVideoSource source(0, 30, 300, 0, 0);
PacedVideoSender sender(&uplink_, &source, GetParam());
+ const int kFlowId = 0;
+ // CreateFlowIds() doesn't support passing int as a flow id, so we pass
+ // pointer instead.
+ DelayFilter delay(&uplink_, CreateFlowIds(&kFlowId, 1));
+ delay.SetOneWayDelayMs(100);
ChokeFilter filter(&uplink_, 0);
RateCounterFilter counter(&uplink_, 0, "Receiver", bwe_names[GetParam()]);
PacketReceiver receiver(&uplink_, 0, GetParam(), true, true);
@@ -262,6 +317,11 @@ TEST_P(BweSimulation, LinearDecreasingCapacity) {
TEST_P(BweSimulation, PacerGoogleWifiTrace3Mbps) {
PeriodicKeyFrameSource source(0, 30, 300, 0, 0, 1000);
PacedVideoSender sender(&uplink_, &source, GetParam());
+ int kFlowId = 0;
+ // CreateFlowIds() doesn't support passing int as a flow id, so we pass
+ // pointer instead.
+ DelayFilter delay(&uplink_, CreateFlowIds(&kFlowId, 1));
+ delay.SetOneWayDelayMs(100);
RateCounterFilter counter1(&uplink_, 0, "sender_output",
bwe_names[GetParam()]);
TraceBasedDeliveryFilter filter(&uplink_, 0, "link_capacity");
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/BUILD.gn ('k') | webrtc/modules/remote_bitrate_estimator/test/bbr_paced_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698