Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2999053002: Fix a delete type mismatch (deleting a sockaddr_in6* as a sockaddr*) (Closed)

Created:
3 years, 4 months ago by oprypin_webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a delete type mismatch (deleting a sockaddr_in6* as a sockaddr*) This triggered ASan, saying "object passed to delete has wrong type". This error is caused by allocating a `struct sockaddr_in6`, casting it and deleting it as `struct sockaddr*` which has a smaller size. BUG=None Review-Url: https://codereview.webrtc.org/2999053002 Cr-Commit-Position: refs/heads/master@{#19401} Committed: https://chromium.googlesource.com/external/webrtc/+/1ea631f4a769305a372cfb8fcf455c10f8f0a8aa

Patch Set 1 #

Patch Set 2 : Rework to use malloc/free #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/rtc_base/network_unittest.cc View 1 3 chunks +7 lines, -3 lines 4 comments Download

Messages

Total messages: 18 (10 generated)
oprypin_webrtc
3 years, 4 months ago (2017-08-16 10:10:08 UTC) #3
oprypin_webrtc
3 years, 4 months ago (2017-08-17 17:08:09 UTC) #5
kwiberg-webrtc
Yeah, I guess this works, but this basically a C data structure that you're manipulating, ...
3 years, 4 months ago (2017-08-17 21:17:35 UTC) #6
oprypin_webrtc
On 2017/08/17 21:17:35, kwiberg-webrtc wrote: > Yeah, I guess this works, but this basically a ...
3 years, 4 months ago (2017-08-17 22:07:52 UTC) #9
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2999053002/diff/20001/webrtc/rtc_base/network_unittest.cc File webrtc/rtc_base/network_unittest.cc (right): https://codereview.webrtc.org/2999053002/diff/20001/webrtc/rtc_base/network_unittest.cc#newcode129 webrtc/rtc_base/network_unittest.cc:129: malloc(sizeof(struct sockaddr_in6))); Note: Unlike in C, in C++ ...
3 years, 4 months ago (2017-08-17 22:18:48 UTC) #10
oprypin_webrtc
https://codereview.webrtc.org/2999053002/diff/20001/webrtc/rtc_base/network_unittest.cc File webrtc/rtc_base/network_unittest.cc (right): https://codereview.webrtc.org/2999053002/diff/20001/webrtc/rtc_base/network_unittest.cc#newcode129 webrtc/rtc_base/network_unittest.cc:129: malloc(sizeof(struct sockaddr_in6))); On 2017/08/17 22:18:48, kwiberg-webrtc wrote: > Note: ...
3 years, 4 months ago (2017-08-18 07:12:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2999053002/20001
3 years, 4 months ago (2017-08-18 07:12:58 UTC) #15
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 07:15:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1ea631f4a769305a372cfb8fc...

Powered by Google App Engine
This is Rietveld 408576698