Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2998133002: Revert of Add Jpeg frame writer for test support. (Closed)

Created:
3 years, 4 months ago by charujain
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add Jpeg frame writer for test support. (patchset #12 id:220001 of https://codereview.webrtc.org/2990563002/ ) Reason for revert: Breaks webrtc.linux Original issue's description: > Add Jpeg frame writer for test support. > > Also, use it to save worst psnr frame in video quality tests. It is indented that these saved frames from perfbots will be uploaded to the cloud and will be available in chrome perf dashboard. Because of that size of the saved frame is somewhat an issue. Also, y4m is not convenient to view. > > BUG=webrtc:8030 > > Review-Url: https://codereview.webrtc.org/2990563002 > Cr-Commit-Position: refs/heads/master@{#19414} > Committed: https://chromium.googlesource.com/external/webrtc/+/26e5cbd6bb38ed734559ab70cb7362870d76c923 TBR=stefan@webrtc.org,pbos@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8030 Review-Url: https://codereview.webrtc.org/2998133002 Cr-Commit-Position: refs/heads/master@{#19419} Committed: https://chromium.googlesource.com/external/webrtc/+/3771ba3002be418e89480f735dbd003c3f129327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -151 lines) Patch
M webrtc/test/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/test/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/test/testsupport/frame_writer.h View 2 chunks +0 lines, -15 lines 0 comments Download
D webrtc/test/testsupport/jpeg_frame_writer.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M webrtc/test/testsupport/test_output.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M webrtc/test/testsupport/test_output_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 3 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
charujain
Created Revert of Add Jpeg frame writer for test support.
3 years, 4 months ago (2017-08-20 19:10:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998133002/1
3 years, 4 months ago (2017-08-20 19:10:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3771ba3002be418e89480f735dbd003c3f129327
3 years, 4 months ago (2017-08-20 19:51:06 UTC) #6
ilnik
3 years, 4 months ago (2017-08-21 08:10:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2998143002/ by ilnik@webrtc.org.

The reason for reverting is: Reland after fixes for broken targets.

Powered by Google App Engine
This is Rietveld 408576698