Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: tests/compiler/dart2js/closure/data/captured_variable.dart

Issue 2998113002: Reduce use of getClosureInfoForMember and cleanup closure_test (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/closure/data/captured_variable.dart
diff --git a/tests/compiler/dart2js/closure/data/captured_variable.dart b/tests/compiler/dart2js/closure/data/captured_variable.dart
index 7546c25148ba87d50285758a3bf4452bd15608c5..7ab8423a7ce417ef2b0142042c1d1632718f2b23 100644
--- a/tests/compiler/dart2js/closure/data/captured_variable.dart
+++ b/tests/compiler/dart2js/closure/data/captured_variable.dart
@@ -13,14 +13,14 @@ readParameterInClosure(/**/ parameter) {
return func;
}
-/*writeParameterInAnonymousClosure:boxed=[parameter],captured=[parameter],requiresBox*/
+/*writeParameterInAnonymousClosure:boxed=[parameter],requiresBox*/
writeParameterInAnonymousClosure(/*boxed*/ parameter) {
return /*boxed=[parameter],captured=[parameter],free=[box,parameter]*/ () {
parameter = 42;
};
}
-/*writeParameterInClosure:boxed=[parameter],captured=[parameter],requiresBox*/
+/*writeParameterInClosure:boxed=[parameter],requiresBox*/
writeParameterInClosure(/*boxed*/ parameter) {
/*boxed=[parameter],captured=[parameter],free=[box,parameter]*/ func() {
parameter = 42;
@@ -42,7 +42,7 @@ readLocalInClosure(/**/ parameter) {
return func;
}
-/*writeLocalInAnonymousClosure:boxed=[local],captured=[local],requiresBox*/
+/*writeLocalInAnonymousClosure:boxed=[local],requiresBox*/
writeLocalInAnonymousClosure(/**/ parameter) {
// ignore: UNUSED_LOCAL_VARIABLE
var /*boxed*/ local = parameter;
@@ -51,7 +51,7 @@ writeLocalInAnonymousClosure(/**/ parameter) {
};
}
-/*writeLocalInClosure:boxed=[local],captured=[local],requiresBox*/
Emily Fortuna 2017/08/22 20:46:17 I'm confused why these get removed now?
Johnni Winther 2017/08/23 07:32:21 Because I'm no longer using .getClosureInfoForMemb
+/*writeLocalInClosure:boxed=[local],requiresBox*/
writeLocalInClosure(/**/ parameter) {
// ignore: UNUSED_LOCAL_VARIABLE
var /*boxed*/ local = parameter;
« no previous file with comments | « tests/compiler/dart2js/closure/closure_test.dart ('k') | tests/compiler/dart2js/equivalence/id_equivalence_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698