Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5369)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 299753011: Move allocate instance id to chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from fady Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.h
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h
index c88de6ccc7362c4f61f68a147c6fa914f3fb219d..5f8f01cf1704d3510a4f35c16bcbf28c54548f3f 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.h
+++ b/chrome/browser/guest_view/web_view/web_view_guest.h
@@ -56,6 +56,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
static int GetViewInstanceId(content::WebContents* contents);
static const char Type[];
+ // Request navigating the guest to the provided |src| URL.
+ void NavigateGuest(const std::string& src);
+
typedef std::vector<linked_ptr<webview_api::ContextMenuItem> > MenuItemVector;
// Shows the context menu for the guest.
// |items| acts as a filter. This restricts the current context's default
@@ -127,7 +130,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,
content::WebContents* new_contents) OVERRIDE;
// GuestDelegate implementation.
- virtual void DidAttach() OVERRIDE;
+ virtual void DidAttach(const base::DictionaryValue& extra_params) OVERRIDE;
virtual void EmbedderDestroyed() OVERRIDE;
virtual bool IsDragAndDropEnabled() OVERRIDE;
virtual void SizeChanged(const gfx::Size& old_size, const gfx::Size& new_size)
@@ -136,7 +139,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,
bool user_gesture,
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) OVERRIDE;
- virtual void NavigateGuest(const std::string& src) OVERRIDE;
virtual void Destroy() OVERRIDE;
// NotificationObserver implementation.

Powered by Google App Engine
This is Rietveld 408576698