[Suggestions] Adding a Thumbnail Manager for the Suggestions Service

chrome/browser/search/suggestions/suggestions_service.h

Index: chrome/browser/search/suggestions/suggestions_service.h
diff --git a/chrome/browser/search/suggestions/suggestions_service.h b/chrome/browser/search/suggestions/suggestions_service.h
index 972cfce63ada136e3d84343cdcf43cd140f1c4e4..40e127dffa2510bd67a3f7179faa94aa36ff7767 100644
--- a/chrome/browser/search/suggestions/suggestions_service.h
+++ b/chrome/browser/search/suggestions/suggestions_service.h
@@ -13,6 +13,7 @@
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "chrome/browser/search/suggestions/proto/suggestions.pb.h"
+#include "chrome/browser/search/suggestions/thumbnail_manager.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "url/gurl.h"
@@ -43,6 +44,13 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
   // fetch request completes.
   void FetchSuggestionsData(ResponseCallback callback);
 
+  // For a given |url|, if a thumbnail URL is known for it, will start the fetch
+  // of the image and |callback|. In the case of a |url| for which the thumbnail
+  // is  not known, the bitmap pointer given to the |callback| will be NULL.
+  void GetURLThumbnail(

[huangs, 2014/05/22 06:17:35]

Suggest that you shorten this to:

// Retrieves stored thumbnail for |url| asynchronously. Returns thumbnail image
a Bitmap pointer to |callback| if found, and NULL otherwise.

Also, you can unwrap the 2 parameters to be aligned at "(".

[Mathieu, 2014/05/22 15:45:51]

Done.

+      const GURL& url,
+      ThumbnailManager::BitmapResponseCallback callback);
+
  private:
   FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData);
 
@@ -68,6 +76,9 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
   // Queue of callbacks. These are flushed when fetch request completes.
   std::vector<ResponseCallback> waiting_requestors_;
 
+  // Used to obtain server thumbnails, if available.
+  scoped_ptr<ThumbnailManager> thumbnail_manager_;
+
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(SuggestionsService);