Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2996163002: support class native clause (Closed)

Created:
3 years, 4 months ago by danrubel
Modified:
3 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add new fasta native clause error code #

Total comments: 20

Patch Set 3 : rebase #

Patch Set 4 : address comments #

Patch Set 5 : rebase and update test #

Patch Set 6 : update DietListener and test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -14 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 2 3 6 chunks +30 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_listener.dart View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 2 3 4 6 chunks +45 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 2 3 2 chunks +19 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/directive_listener.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
danrubel
3 years, 4 months ago (2017-08-17 14:19:04 UTC) #2
danrubel
Revised per discussion. PTAL.
3 years, 4 months ago (2017-08-20 18:37:38 UTC) #3
ahe
This looks good, but there's a few nits below that makes me think another iteration ...
3 years, 4 months ago (2017-08-21 12:04:11 UTC) #4
danrubel
Revised per discussion. PTAL. https://codereview.chromium.org/2996163002/diff/20001/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart File pkg/analyzer/lib/src/dart/error/syntactic_errors.dart (right): https://codereview.chromium.org/2996163002/diff/20001/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart#newcode752 pkg/analyzer/lib/src/dart/error/syntactic_errors.dart:752: " or @native('some-text-here') before the ...
3 years, 4 months ago (2017-08-22 01:35:28 UTC) #5
ahe
lgtm
3 years, 4 months ago (2017-08-22 11:00:52 UTC) #6
danrubel
3 years, 4 months ago (2017-08-22 11:43:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
d1385f099f70cb9e6bbc93052b4d07bc678b197a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698