Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2996093003: Compile with c++14 on android + Roll chromium_revision d323a482ee..c7cea15b71 (494468:495064) (Closed)

Created:
3 years, 4 months ago by ehmaldonado_webrtc
Modified:
3 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Compile with c++14 on android + Roll chromium_revision d323a482ee..c7cea15b71 (494468:495064) Change log: https://chromium.googlesource.com/chromium/src/+log/d323a482ee..c7cea15b71 Full diff: https://chromium.googlesource.com/chromium/src/+/d323a482ee..c7cea15b71 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/66d3c08e82..b0e1fa32e7 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/2a5e6515a5..bee933aa41 * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/ceb050498e..f90f6a5af3 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/2085f316c1..4a764f8fd6 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/3127a16731..9e8798e56f * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b4122f732f..5c0a58eaef * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/f4ecc84644..ae9f0616c5 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d27175a044..cd8447f511 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d0d04458d..e081cbe5aa * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/98218d1e92..08cb956852 * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/cbb83ba4aa..6b9c691daf * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/5730fb2d3f..8d67f78793 DEPS diff: https://chromium.googlesource.com/chromium/src/+/d323a482ee..c7cea15b71/DEPS No update to Clang. TBR=marpan@webrtc.org, BUG=None CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal patch from issue 3001813002 at patchset 1 (http://crrev.com/3001813002#ps1)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M .gn View 1 chunk +0 lines, -3 lines 0 comments Download
M DEPS View 9 chunks +13 lines, -13 lines 0 comments Download
M webrtc/webrtc.gni View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4 (2 generated)
kjellander_webrtc
lgtm with comment addressed https://codereview.webrtc.org/2996093003/diff/1/webrtc/webrtc.gni File webrtc/webrtc.gni (right): https://codereview.webrtc.org/2996093003/diff/1/webrtc/webrtc.gni#newcode199 webrtc/webrtc.gni:199: use_cxx11 = !is_android Add a ...
3 years, 4 months ago (2017-08-17 13:30:01 UTC) #2
ehmaldonado_webrtc
3 years, 4 months ago (2017-08-17 14:48:14 UTC) #3
On 2017/08/17 13:30:01, kjellander_webrtc wrote:
> lgtm with comment addressed
> 
> https://codereview.webrtc.org/2996093003/diff/1/webrtc/webrtc.gni
> File webrtc/webrtc.gni (right):
> 
> https://codereview.webrtc.org/2996093003/diff/1/webrtc/webrtc.gni#newcode199
> webrtc/webrtc.gni:199: use_cxx11 = !is_android
> Add a comment with more background here.

Done in another CL.
android_rel is having problems with gradle_project_test.

Powered by Google App Engine
This is Rietveld 408576698