Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2995163002: Pinpoint - Need to supply --output-format=chartjson (Closed)

Created:
3 years, 4 months ago by shatch
Modified:
3 years, 4 months ago
Reviewers:
dtu
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Pinpoint - Need to supply --output-format=chartjson Looks like run_telemetry_benchmark_as_googletest expects a very specific string, --output-format=chartjson in order to detect chartjson being used. Just changed how we supply that param. BUG=catapult:#3334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dashboard/dashboard/pinpoint/models/quest_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/models/quest_generator_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
shatch
3 years, 4 months ago (2017-08-17 18:17:09 UTC) #2
dtu
Can we fix it in run_telemetry_benchmark_as_googletest.py?
3 years, 4 months ago (2017-08-17 19:24:21 UTC) #7
shatch
3 years, 4 months ago (2017-08-17 19:26:39 UTC) #8
On 2017/08/17 19:24:21, dtu wrote:
> Can we fix it in run_telemetry_benchmark_as_googletest.py?

Sure, I can close this out if you prefer it fixed there instead.

Powered by Google App Engine
This is Rietveld 408576698