Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 29943003: Remove CanChallengePlatform() and CheckPlatformState(). (Closed)

Created:
7 years, 2 months ago by DaleCurtis
Modified:
7 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, yzshen+watch_chromium.org, dkrahn+watch_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove CanChallengePlatform() and CheckPlatformState(). This API did not meet its intended purpose. We've decided to instead just use a real challenge and wait for the response. BUG=307707, 309158 TEST=compile, unittests pass. TBR=pastarmovj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229648

Patch Set 1 #

Patch Set 2 : Remove StatisticsProvider usage. #

Total comments: 2

Patch Set 3 : Remove 0.1 usage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -309 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_flow.h View 1 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 1 4 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 1 6 chunks +1 line, -75 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M ppapi/api/private/ppb_platform_verification_private.idl View 1 2 2 chunks +1 line, -20 lines 0 comments Download
M ppapi/c/private/ppb_platform_verification_private.h View 1 2 5 chunks +6 lines, -24 lines 0 comments Download
M ppapi/cpp/private/platform_verification.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/private/platform_verification.cc View 1 2 2 chunks +5 lines, -14 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 5 chunks +17 lines, -23 lines 0 comments Download
M ppapi/proxy/platform_verification_private_resource.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/proxy/platform_verification_private_resource.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/tests/test_platform_verification_private.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_platform_verification_private.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_platform_verification_api.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_platform_verification_private_thunk.cc View 1 2 3 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
DaleCurtis
pastarmovj, dkrahn: chrome/browser/chromeos/attestation/ tsepez: ppapi/proxy/ppapi_message.h dmichael: Pepper changes.
7 years, 2 months ago (2013-10-18 21:34:18 UTC) #1
Darren Krahn
On 2013/10/18 21:34:18, DaleCurtis wrote: > pastarmovj, dkrahn: chrome/browser/chromeos/attestation/ > tsepez: ppapi/proxy/ppapi_message.h > dmichael: Pepper ...
7 years, 2 months ago (2013-10-18 21:38:47 UTC) #2
DaleCurtis
Want to just drop that one in favor of this complete cleanup?
7 years, 2 months ago (2013-10-18 21:39:43 UTC) #3
Darren Krahn
On 2013/10/18 21:39:43, DaleCurtis wrote: > Want to just drop that one in favor of ...
7 years, 2 months ago (2013-10-18 21:41:37 UTC) #4
DaleCurtis
+tsepez for real for ppapi/proxy/ppapi_messages.h dkrahn: Done, all pulled in.
7 years, 2 months ago (2013-10-18 21:45:46 UTC) #5
Tom Sepez
Rubberstamp LGTM on ppapi_messages.h for deleting code.
7 years, 2 months ago (2013-10-18 21:50:09 UTC) #6
Darren Krahn
On 2013/10/18 21:45:46, DaleCurtis wrote: > +tsepez for real for ppapi/proxy/ppapi_messages.h > > dkrahn: Done, ...
7 years, 2 months ago (2013-10-18 21:50:38 UTC) #7
dmichael (off chromium)
https://chromiumcodereview.appspot.com/29943003/diff/70001/ppapi/api/private/ppb_platform_verification_private.idl File ppapi/api/private/ppb_platform_verification_private.idl (right): https://chromiumcodereview.appspot.com/29943003/diff/70001/ppapi/api/private/ppb_platform_verification_private.idl#newcode14 ppapi/api/private/ppb_platform_verification_private.idl:14: M31 = 0.1, Since you're not providing backwards compatibility, ...
7 years, 2 months ago (2013-10-18 22:00:29 UTC) #8
DaleCurtis
Since pastarmovj already approved the CL I pulled in a TBR should be fine. https://chromiumcodereview.appspot.com/29943003/diff/70001/ppapi/api/private/ppb_platform_verification_private.idl ...
7 years, 2 months ago (2013-10-18 22:07:13 UTC) #9
dmichael (off chromium)
lgtm
7 years, 2 months ago (2013-10-18 22:12:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/29943003/140001
7 years, 2 months ago (2013-10-18 22:58:02 UTC) #11
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=90739
7 years, 2 months ago (2013-10-19 11:58:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/29943003/140001
7 years, 2 months ago (2013-10-19 20:03:43 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-20 01:34:29 UTC) #14
Message was sent while issue was closed.
Change committed as 229648

Powered by Google App Engine
This is Rietveld 408576698