Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 298653007: Revert of Remove override of View::HitTestRect() from BookmarkBarView (Closed)

Created:
6 years, 7 months ago by tdanderson
Modified:
6 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of Remove override of View::HitTestRect() from BookmarkBarView (https://chromiumcodereview.appspot.com/286313003/) Reason for revert: Items on the bookmark bar can still be highlighted and tooltips are shown when the omnibox popup is open. tdanderson@ will investigate. Original issue's description: > Remove override of View::HitTestRect() from BookmarkBarView > > The override of View::HitTestRect() in BookmarkBarView checks > for the state of the omnibox popup to determine whether or not the > bookmark bar can accept events. Since this is unrelated to location, > it is better to move this logic into an override of > EventTarget::CanAcceptEvent() instead. > > BUG=374340 > TEST=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272133 TBR=sadrul@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=374340 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tdanderson
Created Revert of Remove override of View::HitTestRect() from BookmarkBarView
6 years, 7 months ago (2014-05-22 21:18:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/298653007/1
6 years, 7 months ago (2014-05-22 21:19:38 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 21:21:44 UTC) #3
Message was sent while issue was closed.
Change committed as 272318

Powered by Google App Engine
This is Rietveld 408576698