Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2980863004: [Telemetry] Assert that android devices are rooted when running telemetry. (Closed)

Created:
3 years, 5 months ago by rnephew (Reviews Here)
Modified:
3 years, 4 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Assert that android devices are rooted when running telemetry. Large portions of the telemetry code base assumes android devices will be rooted. BUG=catapult:#3672 Review-Url: https://codereview.chromium.org/2980863004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/28fb1abdfc1e814c0147c5f2412888a595366a26

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
rnephew (Reviews Here)
3 years, 5 months ago (2017-07-14 15:07:12 UTC) #4
perezju
lgtm should an announcement be sent before landing? I wouldn't be surprised if some people ...
3 years, 5 months ago (2017-07-14 15:34:23 UTC) #7
nednguyen
On 2017/07/14 15:34:23, perezju wrote: > lgtm > > should an announcement be sent before ...
3 years, 5 months ago (2017-07-14 15:37:26 UTC) #8
rnephew (Reviews Here)
On 2017/07/14 15:37:26, nednguyen wrote: > On 2017/07/14 15:34:23, perezju wrote: > > lgtm > ...
3 years, 5 months ago (2017-07-14 15:44:40 UTC) #9
nednguyen
On 2017/07/14 15:44:40, rnephew (Reviews Here) wrote: > On 2017/07/14 15:37:26, nednguyen wrote: > > ...
3 years, 5 months ago (2017-07-14 15:46:28 UTC) #10
perezju
On 2017/07/14 15:46:28, nednguyen wrote: > On 2017/07/14 15:44:40, rnephew (Reviews Here) wrote: > > ...
3 years, 4 months ago (2017-08-17 08:12:56 UTC) #11
rnephew (Reviews Here)
On 2017/08/17 08:12:56, perezju wrote: > On 2017/07/14 15:46:28, nednguyen wrote: > > On 2017/07/14 ...
3 years, 4 months ago (2017-08-17 15:08:19 UTC) #12
rnephew (Reviews Here)
On 2017/08/17 15:08:19, rnephew (Reviews Here) wrote: > On 2017/08/17 08:12:56, perezju wrote: > > ...
3 years, 4 months ago (2017-08-17 17:44:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980863004/20001
3 years, 4 months ago (2017-08-21 17:30:39 UTC) #20
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 17:57:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698