Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 296853005: Improve ASLR for arm64

Created:
6 years, 7 months ago by danno
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve ASLR for arm64 R=ulan@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/platform-posix.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
danno
6 years, 7 months ago (2014-05-21 07:13:37 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-05-21 07:20:03 UTC) #2
Rodolph Perfetta
https://chromiumcodereview.appspot.com/296853005/diff/1/src/platform-posix.cc File src/platform-posix.cc (right): https://chromiumcodereview.appspot.com/296853005/diff/1/src/platform-posix.cc#newcode209 src/platform-posix.cc:209: // Currently available CPUs have 40 bits of virtual ...
6 years, 7 months ago (2014-05-21 08:00:08 UTC) #3
danno
Thanks for the heads-up, Rodolph. So, should arm64 work exactly like x64? i.e. use a ...
6 years, 7 months ago (2014-05-21 09:40:45 UTC) #4
Rodolph Perfetta
6 years, 7 months ago (2014-05-21 10:01:01 UTC) #5
On 2014/05/21 09:40:45, danno wrote:
> Thanks for the heads-up, Rodolph. So, should arm64 work exactly like x64? i.e.
> use a 46 bit hint? Chris, where did you get the 48/38 bit constraint?

I should have been more accurate. The architecture support 48 bits addresses,
but how many bits is available will depend on the kernel config: with 4k pages
and 3 level of page table then you "only" have 40 bits of addresses, which is
probably where the initial number comes from. The kernel can be configured to
have a wider range of addresses using more page table levels or using 64k pages.
I guess going for the lowest denominator is the right thing to do. Updating the
comment would be good though.

Powered by Google App Engine
This is Rietveld 408576698