Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4274)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java

Issue 2963013002: [TTS] Fix for tap on a previous tap-selection. (Closed)
Patch Set: Updated the CSInternalStateTest. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java
index 8151381908bed71672bc3e701bc20544c175effe..9e1f23bb4411e8fdde15497af4174b01f3add278 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInternalStateHandler.java
@@ -13,51 +13,60 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChange
public interface ContextualSearchInternalStateHandler {
/**
* Hides the Contextual Search user interface.
- * {@See ContextualSearchInternalStateController#InternalState#IDLE}.
+ * @see ContextualSearchInternalStateController.InternalState#IDLE
*/
void hideContextualSearchUi(StateChangeReason reason);
/**
* Shows the Contextual Search user interface for a Tap.
- * {@See ContextualSearchInternalStateController#InternalState#SHOW_FULL_TAP_UI}.
+ * @see ContextualSearchInternalStateController.InternalState#SHOW_FULL_TAP_UI
*/
void showContextualSearchTapUi();
/**
* Shows the Contextual Search user interface for a Long-press.
- * {@See ContextualSearchInternalStateController#InternalState#SHOWING_LONGPRESS_SEARCH}.
+ * @see ContextualSearchInternalStateController.InternalState#SHOWING_LONGPRESS_SEARCH
*/
void showContextualSearchLongpressUi();
/**
* Gathers text surrounding the current selection, which may have been created by either a Tap
* or a Long-press gesture.
- * {@See ContextualSearchInternalStateController#InternalState#GATHERING_SURROUNDINGS}.
+ * @see ContextualSearchInternalStateController.InternalState#GATHERING_SURROUNDINGS
*/
void gatherSurroundingText();
/**
* Starts the process of deciding if we'll suppress the current gesture or not.
- * {@See ContextualSearchInternalStateController#InternalState#DECIDING_SUPPRESSION}.
+ * @see ContextualSearchInternalStateController.InternalState#DECIDING_SUPPRESSION
*/
void decideSuppression();
/**
* Starts the process of selecting a word around the current caret.
- * {@See ContextualSearchInternalStateController#InternalState#START_SHOWING_TAP_UI}.
+ * @see ContextualSearchInternalStateController.InternalState#START_SHOWING_TAP_UI
*/
void startShowingTapUi();
/**
- * Waits to see if a Tap gesture will be made when a previous Tap was recognized.
- * {@See
- * ContextualSearchInternalStateController#InternalState#WAITING_FOR_POSSIBLE_TAP_NEAR_PREVIOUS}
+ * Waits to see if a Tap gesture will be made when the selection has been cleared, which allows
+ * a Tap near a previous Tap to be handled without a hide/show of the UI.
+ * @see
+ * ContextualSearchInternalStateController.InternalState#WAITING_FOR_POSSIBLE_TAP_NEAR_PREVIOUS
*/
void waitForPossibleTapNearPrevious();
+ /**
+ * Waits to see if a Tap gesture will be made on a previous Tap-selection when a Tap was
+ * recognized.
+ * @see ContextualSearchInternalStateController.InternalState#
+ * WAITING_FOR_POSSIBLE_TAP_ON_TAP_SELECTION
+ */
+ void waitForPossibleTapOnTapSelection();
+
/**
* Starts a Resolve request to our server for the best Search Term.
- * {@See ContextualSearchInternalStateController#InternalState#RESOLVING}.
+ * @see ContextualSearchInternalStateController.InternalState#RESOLVING
*/
void resolveSearchTerm();
}

Powered by Google App Engine
This is Rietveld 408576698