Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: pkg/analysis_server/test/src/utilities/profiling_test.dart

Issue 2959643002: Fix an issue calculating analysis server cpu usage. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/utilities/profiling.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/src/utilities/profiling_test.dart
diff --git a/pkg/analysis_server/test/src/utilities/profiling_test.dart b/pkg/analysis_server/test/src/utilities/profiling_test.dart
index 4151af7fe4c4e88a34f5718f39e4e90345d2786d..4906c4bc7b7acfec8caac0d48c59d53baaa14012 100644
--- a/pkg/analysis_server/test/src/utilities/profiling_test.dart
+++ b/pkg/analysis_server/test/src/utilities/profiling_test.dart
@@ -18,14 +18,13 @@ main() {
expect(ProcessProfiler.getProfilerForPlatform(), isNotNull);
});
- // TODO: https://github.com/dart-lang/sdk/issues/29815
-// test('getProcessUsage', () async {
-// ProcessProfiler profiler = ProcessProfiler.getProfilerForPlatform();
-// UsageInfo info = await profiler.getProcessUsage(pid);
-//
-// expect(info, isNotNull);
-// expect(info.cpuPercentage, greaterThanOrEqualTo(0.0));
-// expect(info.memoryKB, greaterThanOrEqualTo(0));
-// });
+ test('getProcessUsage', () async {
+ ProcessProfiler profiler = ProcessProfiler.getProfilerForPlatform();
+ UsageInfo info = await profiler.getProcessUsage(pid);
+
+ expect(info, isNotNull);
+ expect(info.cpuPercentage, greaterThanOrEqualTo(0.0));
+ expect(info.memoryKB, greaterThanOrEqualTo(0));
+ });
});
}
« no previous file with comments | « pkg/analysis_server/lib/src/utilities/profiling.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698