third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp - Issue 2959613002: Rename TaskRunner::RunsTasksOnCurrentThread() in //third_party

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

Issue 2959613002: Rename TaskRunner::RunsTasksOnCurrentThread() in //third_party (Closed)

Patch Set: Remove comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/WebTaskRunner.cpp ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

diff --git a/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp b/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

index c56e36a45229935f16d85f96a7cfccbef01c1c11..85397741d9f7942114145bb7d0f5650ef7726aa1 100644

--- a/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

+++ b/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp

@@ -218,7 +218,7 @@ void NetworkStateNotifier::NotifyObserversOnTaskRunner(

if (!observer_list)

return;

- DCHECK(task_runner->RunsTasksOnCurrentThread());

+ DCHECK(task_runner->RunsTasksInCurrentSequence());

observer_list->iterating = true;

@@ -249,7 +249,7 @@ void NetworkStateNotifier::NotifyObserversOnTaskRunner(

void NetworkStateNotifier::AddObserver(ObserverListMap& map,

NetworkStateObserver* observer,

PassRefPtr<WebTaskRunner> task_runner) {

- DCHECK(task_runner->RunsTasksOnCurrentThread());

+ DCHECK(task_runner->RunsTasksInCurrentSequence());

DCHECK(observer);

MutexLocker locker(mutex_);

@@ -265,7 +265,7 @@ void NetworkStateNotifier::AddObserver(ObserverListMap& map,

void NetworkStateNotifier::RemoveObserver(ObserverListMap& map,

NetworkStateObserver* observer,

RefPtr<WebTaskRunner> task_runner) {

- DCHECK(task_runner->RunsTasksOnCurrentThread());

+ DCHECK(task_runner->RunsTasksInCurrentSequence());

DCHECK(observer);

ObserverList* observer_list = LockAndFindObserverList(map, task_runner);

@@ -296,7 +296,7 @@ void NetworkStateNotifier::CollectZeroedObservers(

ObserverListMap& map,

ObserverList* list,

PassRefPtr<WebTaskRunner> task_runner) {

- DCHECK(task_runner->RunsTasksOnCurrentThread());

+ DCHECK(task_runner->RunsTasksInCurrentSequence());

DCHECK(!list->iterating);

// If any observers were removed during the iteration they will have