Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: client/cmd/isolate/batch_archive_test.go

Issue 2954893002: Enter a description of the change.
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/isolate/utils.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/cmd/isolate/batch_archive_test.go
diff --git a/client/cmd/isolate/batch_archive_test.go b/client/cmd/isolate/batch_archive_test.go
index 7e70d5e9c6ac308b685c47b1363e259d65edb031..80ed68e92dc25703ba9134ea4bd1d6fdf100f335 100644
--- a/client/cmd/isolate/batch_archive_test.go
+++ b/client/cmd/isolate/batch_archive_test.go
@@ -9,7 +9,7 @@ import (
"strings"
"testing"
- "github.com/luci/luci-go/client/internal/common"
+ "github.com/luci/luci-go/client/isolate"
"github.com/luci/luci-go/common/flag/stringmapflag"
. "github.com/smartystreets/goconvey/convey"
@@ -91,7 +91,7 @@ func TestArchiveCMDParsing(t *testing.T) {
So(opts.Isolated, ShouldResemble, filepath.Join(base, "biz", "bar.isolated"))
So(err, ShouldBeNil)
So(stringmapflag.Value{"OS": "linux"}, ShouldResemble, opts.ConfigVariables)
- if common.IsWindows() {
+ if isolate.IsWindows() {
So(stringmapflag.Value{"PRODUCT_DIR": "../../out/Release", "EXECUTABLE_SUFFIX": ".exe", "DEPTH": "../.."}, ShouldResemble, opts.PathVariables)
} else {
So(stringmapflag.Value{"PRODUCT_DIR": "../../out/Release", "EXECUTABLE_SUFFIX": "", "DEPTH": "../.."}, ShouldResemble, opts.PathVariables)
@@ -121,7 +121,7 @@ func TestArchiveAbsolutePaths(t *testing.T) {
// absToOS converts a POSIX path to OS specific format.
func absToOS(drive, p string) string {
- if common.IsWindows() {
+ if isolate.IsWindows() {
return drive + strings.Replace(p, "/", "\\", -1)
}
return p
« no previous file with comments | « no previous file | client/isolate/utils.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698