chrome/browser/guest_view/guest_view_manager.cc - Issue 295083002: BrowserPluginGuest is no longer a WebContentsDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_manager.cc

Issue 295083002: BrowserPluginGuest is no longer a WebContentsDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_context_menu_easier_to_refactor

Patch Set: Fixed content_browsertests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | content/public/browser/browser_plugin_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/guest_view_manager.cc

diff --git a/chrome/browser/guest_view/guest_view_manager.cc b/chrome/browser/guest_view/guest_view_manager.cc

index 782ced5e1eb09d7c5f63501e950c4fc31cdf4d15..efd5708e35a70a7899c6c65080c61eb31e832eaf 100644

--- a/chrome/browser/guest_view/guest_view_manager.cc

+++ b/chrome/browser/guest_view/guest_view_manager.cc

@@ -247,7 +247,7 @@ bool GuestViewManager::CanEmbedderAccessInstanceIDMaybeKill(

int embedder_render_process_id,

int guest_instance_id) {

if (!CanEmbedderAccessInstanceID(embedder_render_process_id,

- guest_instance_id)) {

+ guest_instance_id)) {

// The embedder process is trying to access a guest it does not own.

content::RecordAction(

base::UserMetricsAction("BadMessageTerminate_BPGM"));