Introduce create_nonsfi_test_nmf.py to simplify nacl_test_data.gyp

ppapi/ppapi_nacl_test_common.gypi

Index: ppapi/ppapi_nacl_test_common.gypi
diff --git a/ppapi/ppapi_nacl_test_common.gypi b/ppapi/ppapi_nacl_test_common.gypi
index 0d9b676884821509868a0cb8600822b1f6d9e91c..46accc6b114aa6bbba2db60b37de31354ae1ad7b 100644
--- a/ppapi/ppapi_nacl_test_common.gypi
+++ b/ppapi/ppapi_nacl_test_common.gypi
@@ -35,6 +35,7 @@
           'out_pnacl_newlib%': '>(nacl_pnacl_newlib_out_dir)/>(nexe_target)_newlib_pnacl.pexe',
           'nmf_pnacl_newlib%': '>(nacl_pnacl_newlib_out_dir)/>(nexe_target).nmf',
           'out_pnacl_newlib_x86_32_nonsfi_nexe': '>(nacl_pnacl_newlib_nonsfi_out_dir)/>(nexe_target)_pnacl_newlib_x32_nonsfi.nexe',
+          'nmf_pnacl_newlib_nonsfi%': '>(nacl_pnacl_newlib_nonsfi_out_dir)/>(nexe_target).nmf',
         }],
       ],
     },
@@ -64,8 +65,8 @@
           },
         ],
       }],
-      # Nonsfi pnacl copy is covered below. Currently, these are exclusive.
-      ['test_files!=[] and build_pnacl_newlib==1 and disable_pnacl==0 and enable_x86_32_nonsfi==0', {
+      # Nonsfi pnacl copy is covered below.
+      ['test_files!=[] and build_pnacl_newlib==1 and disable_pnacl==0 and (enable_x86_32==1 or enable_x86_64==1 or enable_arm==1 or enable_mips==1)', {

[dmichael (off chromium), 2014/05/20 19:45:35]

These conditionals are getting pretty big and hard-to-read.

Is there any way to make a variable and conditional that would wrap up all the
architectures? Something like:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

[hidehiko, 2014/05/21 13:25:32]

Due to evaluation order, it seems to cause a gyp error.
I'm thinking that introducing a new variable makes the gyp more readable as I
replied to Mark. Please let me try to work on it in a separate CL.

         'copies': [
           {
             'destination': '>(nacl_pnacl_newlib_out_dir)',
@@ -106,6 +107,7 @@
           ],
           'create_nmf': '<(DEPTH)/native_client_sdk/src/tools/create_nmf.py',
           'create_nmf_args_portable%': [],
+          'create_nonsfi_test_nmf': '<(DEPTH)/ppapi/tests/create_nonsfi_test_nmf.py',
         },
         'target_conditions': [
           ['generate_nmf==1 and build_newlib==1', {
@@ -188,7 +190,7 @@
               },
             ],
           }],
-          ['generate_nmf==1 and build_pnacl_newlib==1 and disable_pnacl==0', {
+          ['generate_nmf==1 and build_pnacl_newlib==1 and disable_pnacl==0 and (enable_x86_32==1 or enable_x86_64==1 or enable_arm==1 or enable_mips==1)', {
             'actions': [
               {
                 'action_name': 'Generate PNACL NEWLIB NMF',
@@ -206,6 +208,26 @@
               },
             ],
           }],
+          ['generate_nmf==1 and build_pnacl_newlib==1 and disable_pnacl==0 and enable_x86_32_nonsfi==1', {
+            'actions': [
+              {
+                'action_name': 'Generate PNACL NEWLIB nonsfi NMF',
+                # If we add support for ARM, we should split the dependency on
+                # out_pnacl_newlib_x86_32_nonsfi_nexe to 'target_conditions',
+                # similar to build_newlib=1 config declared above.
+                'inputs': ['>(create_nonsfi_test_nmf)',
+                           '>(out_pnacl_newlib_x86_32_nonsfi_nexe)'],
+                'outputs': ['>(nmf_pnacl_newlib_nonsfi)'],
+                'action': [
+                  'python',
+                  '>(create_nonsfi_test_nmf)',
+                  '--output=>(nmf_pnacl_newlib_nonsfi)',
+                  '--program=>(out_pnacl_newlib_x86_32_nonsfi_nexe)',
+                  '>@(create_nmf_args_portable)'
+                ],
+              },
+            ],
+          }],
         ],
       }],
     ],