Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/content_settings/core/common/content_settings.mojom

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)
Patch Set: rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/content_settings.mojom
diff --git a/components/content_settings/core/common/content_settings.mojom b/components/content_settings/core/common/content_settings.mojom
index 5c4c5d92a929b7ef081380b46180bdb477d0e61e..3669aec081a998f8b1eddba8350caf78556b0fcb 100644
--- a/components/content_settings/core/common/content_settings.mojom
+++ b/components/content_settings/core/common/content_settings.mojom
@@ -4,6 +4,8 @@
module content_settings.mojom;
+import "mojo/common/values.mojom";
+
// This mirrors the C++ type in content_settings_pattern.h.
struct PatternParts {
// Lowercase string of the URL scheme to match. This string is empty if the
@@ -59,7 +61,7 @@ enum ContentSetting {
struct ContentSettingPatternSource {
ContentSettingsPattern primary_pattern;
ContentSettingsPattern secondary_pattern;
- ContentSetting setting;
+ mojo.common.mojom.Value setting_value;
string source;
bool incognito;
};

Powered by Google App Engine
This is Rietveld 408576698