Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1781)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 2938163002: Store base::Value in ContentSettingPatternSource instead of an enum (Closed)
Patch Set: rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index cd287187c009fc6e4ae276afdff4fe12a7bd5c63..bc556642ccc1dff606606bd39537a5479e02b1b5 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -75,7 +75,7 @@ std::set<GURL> GetEngagementOriginsFromContentSettings(Profile* profile) {
// Fetch URLs of sites for which notifications are allowed.
for (const auto& site : GetContentSettingsFromProfile(
profile, CONTENT_SETTINGS_TYPE_NOTIFICATIONS)) {
- if (site.setting != CONTENT_SETTING_ALLOW)
+ if (site.GetContentSetting() != CONTENT_SETTING_ALLOW)
continue;
urls.insert(GURL(site.primary_pattern.ToString()));
}

Powered by Google App Engine
This is Rietveld 408576698