Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: components/metrics/proto/translate_event.proto

Issue 2938133003: Split translate_event.proto AUTOMATICALLY_TRANSLATED. (Closed)
Patch Set: updates Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/protocol/proto_enum_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/translate_event.proto
diff --git a/components/metrics/proto/translate_event.proto b/components/metrics/proto/translate_event.proto
index fb9717372c832f861e2c213e21076df0fd2d97e1..c2ced5c8849dc5a296efa103995e5e59fae4bb1a 100644
--- a/components/metrics/proto/translate_event.proto
+++ b/components/metrics/proto/translate_event.proto
@@ -67,6 +67,7 @@ message TranslateEventProto {
optional RankerResponse ranker_response = 9;
// The action performed by the user in the translate UI.
+ // Next tag 27.
enum EventType {
// The feedback event does not correspond to any of the enumerated
// cases.
@@ -92,9 +93,15 @@ message TranslateEventProto {
// The user reverted the translation.
USER_REVERT = 9;
+ // Deprecated. Use AUTO_TRANSLATION_BY_PREF or AUTO_TRANSLATION_BY_LINK
+ // instead.
+ AUTOMATICALLY_TRANSLATED = 10;
// Automated feedback.
// An automatic translation was triggered.
- AUTOMATICALLY_TRANSLATED = 10;
+ // User sets always translate in user settings.
+ AUTO_TRANSLATION_BY_PREF = 25;
+ // User navigated through a click from a translated page.
+ AUTO_TRANSLATION_BY_LINK = 26;
// The translation was not offered because translate is disabled
// globally in the user preferences.
DISABLED_BY_PREF = 11;
« no previous file with comments | « no previous file | components/sync/protocol/proto_enum_conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698