webrtc/base/win32filesystem.cc - Issue 2935933007: Delete class DirectoryIterator and FileRotatingStream read support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/win32filesystem.cc

Issue 2935933007: Delete class DirectoryIterator and FileRotatingStream read support. (Closed)

Patch Set: Drop an RTC_NOTREACHED. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/win32filesystem.cc

diff --git a/webrtc/base/win32filesystem.cc b/webrtc/base/win32filesystem.cc

index 5445140ef2b1d8655440b20614b7c93c3bd248a8..109c2ce819c69a859af4c166e1db59b42ac3ef67 100644

--- a/webrtc/base/win32filesystem.cc

+++ b/webrtc/base/win32filesystem.cc

@@ -66,7 +66,6 @@ bool Win32Filesystem::CreateFolder(const Pathname &pathname) {

bool Win32Filesystem::DeleteFile(const Pathname &filename) {

LOG(LS_INFO) << "Deleting file " << filename.pathname();

if (!IsFile(filename)) {

- RTC_DCHECK(IsFile(filename));

return false;

}

return ::DeleteFile(ToUtf16(filename.pathname()).c_str()) != 0;