Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: client/isolate/utils.go

Issue 2934303003: Remove another dependency on common.IsWindows (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/cmd/isolate/batch_archive_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/isolate/utils.go
diff --git a/client/isolate/utils.go b/client/isolate/utils.go
index b66ab49e66264eaa6e71b03458d83b9fef666558..8da1e4464feb6ea697f5fa5403e0fce795a39399 100644
--- a/client/isolate/utils.go
+++ b/client/isolate/utils.go
@@ -137,5 +137,7 @@ func posixRel(basepath, targpath string) (string, error) {
// IsWindows returns True when running on the best OS there is.
func IsWindows() bool {
+ // TODO: once there is a top-level isolate directory with cmd and cli
+ // subdirs, move IsWindows into an isolate/internal package.
return runtime.GOOS == "windows"
}
« no previous file with comments | « client/cmd/isolate/batch_archive_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698