Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2918003002: Remove text_ prefixes from the views::style::Get* helper args. (Closed)

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove text_ prefixes from the views::style::Get* helper args. This makes it consistent with the TypographyProvider interface. BUG=691891 Review-Url: https://codereview.chromium.org/2918003002 Cr-Commit-Position: refs/heads/master@{#476932} Committed: https://chromium.googlesource.com/chromium/src/+/115f6f8b1cb43f0c2d8a32ff54774a6ff3212eb3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M ui/views/style/typography.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M ui/views/style/typography.cc View 1 1 chunk +15 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
tapted
(maybe my penchant for short names has been getting stronger while waiting for my hand ...
3 years, 6 months ago (2017-06-02 01:48:06 UTC) #12
Peter Kasting
LGTM Pretty soon it'll just be (int c, int s).
3 years, 6 months ago (2017-06-02 01:50:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918003002/20001
3 years, 6 months ago (2017-06-05 01:50:20 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 03:11:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/115f6f8b1cb43f0c2d8a32ff5477...

Powered by Google App Engine
This is Rietveld 408576698